ContentEntityForm::validateForm() pointlessly returns $entity

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

patch for 10.1.x

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

try to fix ccf error

Update the patch to resolve error in #22 there is some assertion fail error thrown as some gin theme added so i have reverted it back.

sorry, whitespace need to be fixed.

Hi patch applied cleanly.
Whitespace wasn't encountered.
Test is passing.
I'm using drupal10.1 version
It sounds good to me.

1. +++ b/core/lib/Drupal/Core/Entity/ContentEntityForm.php
   @@ -215,9 +215,8 @@ public function validateForm(array &$form, FormStateInterface $form_state) {
   -    $form_state->setTemporaryValue('entity_validated', TRUE);
   

   I don't think we should be removing this

2. +++ b/core/lib/Drupal/Core/Entity/ContentEntityForm.php
   @@ -215,9 +215,8 @@ public function validateForm(array &$form, FormStateInterface $form_state) {
   +    return $form_state;
   

   I'm a little confused, wasn't the goal to remove the return from this?

Also still needs a subsystem review, and tests haven't run on the last few patches

Addressing #26

Removing credit for #20 and #27 as you should check your patch before uploading. Also all patches should be uploaded with an interdiff.

IS could use some love as the patches seem to be go all over the place and should be documented what's being addressed.

Apologies for not putting the interdiff @smustgrave and thanks for letting us know how to work better this is the way we will improve and help the community in a better way.