๐Ÿ‡ฎ๐Ÿ‡ณIndia @Vidushi Mehta

Account created on 8 November 2014, over 9 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Hi @Gogigigo, I've tested this on Drupal 10 with Adaptive theme but I can see the comment window, attaching the screenshot for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Vidushi Mehta โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I've reviewed the patch #6 but still find the alignment issue, Attaching the before and after screenshots for the same. I am keeping the status same as Needs review so that we'll have more reviews on this

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I've checked the people and content pages and I couldn't see the double check boxes issue, I've installed the "DraggableViews" module to check the issue as mentioned by #10 but still not seeing any double check boxes and not even with the "Big pipe" module.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

@quietone, The reason for the error was that Windows uses a different syntax for setting environment variables compared to Unix-based systems, The LC_ALL environment variable is specific to Unix-based systems, and it is not recognized in the same way on Windows which throws an error and its forcefully removing the content from the dictionary.txt file.

Working fine on Linux RTBC+1

Thanks for the reroll

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Adding a patch for the same to solve this issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Reviewed the patch, the chevron is vertically top aligned after patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I got to know my mistake and found the same issue in force color mode, I've applied #2 for review but it does not apply so adding the new patch for the same and attaching the screenshot of the existing issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I checked this issue by above mentioned steps to reproduce but couldn't find the same after enabling the high contrast mode, attaching the screenshot for the same

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I've reviewed both the patches ( #7 and #8 ) and verified that #8 resolved the issue. Added the screenshots of after applying both the patches for more clarity.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

@lokeshsahu, to check this you need to run 'npm run dev' after applying the patch in local, then the change in scss file will reflect.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

@Mukeysh tested your patch, this issue is still not resolved. Added screenshot for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Added a rerolled patch as #2 was not applying on the latest code
Added before and after screenshots for the same

I've checked on 11.x this issue is showing there as well

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Added a patch which is targeting the password strength as mentioned by the @kopeboy, I've checked on Olivero theme, same issue is showing there as well. Added before & after screenshots of the claro theme and one screenshot for the Olivero.

@lauriii are we removing the class as it should not be repeated on the child selector? Or any other specific reason for that please confirm

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Added a patch for the same

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

@admin_juhisingh your patch is working fine and navigation menu's are visible after applying the patch but, as I've looked into the code and in the header file they have specified the navbar-dark and navbar-light css and under navbar-dark they have added the light color and under navbar-light they have added the dark color for the links so that is the reason for the color invisibility.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Yes, created an interdiff between 43-49 patches

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

This patch only addressing the second point mentioned by #48

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

Apologies for not putting the interdiff @smustgrave and thanks for letting us know how to work better this is the way we will improve and help the community in a better way.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

I've run this command but it throwing error with the command failed and my dictionary got blanked.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

#37 was applying on 9.5.x after the latest pull, adding a patch for 9.5.x for the same.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Vidushi Mehta

#18 was not applying on big_pipe.js with the latest pull so rerolled the patch with #21 comment.

Production build 0.69.0 2024