- Issue created by @bnjmnm
- Status changed to Needs review
over 1 year ago 7:36am 27 July 2023 - last update
over 1 year ago 29,884 pass - 🇮🇳India Harish1688 India
Hi,
Reproduced the issue on local and created a patch for issue 'details up chevron not quite vertically aligned in forced color mode'. attached a image for reference.
Test Steps:
1. setup the Drupal 11.x and claro theme as backend theme=.
2. moved on path 'admin/config/system/site-information
' and active the forced color in browser, and verified the issue (chevron not align vertically).
3. create 3377198-3.patch , Need Review.After Patch:
- Status changed to RTBC
over 1 year ago 9:36am 27 July 2023 - 🇮🇳India Vidushi Mehta
Reviewed the patch, the chevron is vertically top aligned after patch.
- last update
over 1 year ago 29,887 pass - last update
over 1 year ago 29,910 pass - last update
over 1 year ago 29,946 pass 11:37 8:08 Running- last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,953 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,958 pass - last update
over 1 year ago 29,959 pass - Status changed to Needs work
over 1 year ago 9:28am 16 August 2023 - 🇬🇧United Kingdom longwave UK
+++ b/core/themes/claro/css/components/details.css @@ -310,7 +310,7 @@ td .claro-details { + margin-top: calc(0.125rem / -1);
Why not just
margin-top: -0.125rem;
?
Side-by-side screenshots from before and after would help as well.
- Status changed to Needs review
over 1 year ago 12:04pm 16 August 2023 - last update
over 1 year ago 29,961 pass - 🇮🇳India Vidushi Mehta
I've reviewed the patch #6 but still find the alignment issue, Attaching the before and after screenshots for the same. I am keeping the status same as Needs review so that we'll have more reviews on this
- 🇷🇺Russia kostyashupenko Omsk
We don't need top alignment. It should be vertically centered
- Status changed to RTBC
over 1 year ago 1:35pm 21 August 2023 - last update
over 1 year ago 30,049 pass, 1 fail The last submitted patch, 6: 3377198-6.patch, failed testing. View results →
Looks like this is already aligned I measured with a ruler and the arrow top and bottom height is 19px
See screenshots for reference.- 🇺🇸United States bnjmnm Ann Arbor, MI
@shweta__sharma Perhaps I'm misreading your images, but the issue specifies this is related the up-pointing chevron, and both screenshots you provided are examining the down-pointing one.
Yes @bnjmnm You are correct I was checking only up-pointing chevron. Down-pointing chevron icon has a 1-2 point px issue.
Issue summary Updated. I don't think it has any pending work left. Based on #5 Moving status to RTBC now
Thanks- Status changed to RTBC
11 months ago 5:43am 22 January 2024 - Status changed to Needs work
10 months ago 10:47am 22 February 2024 - 🇫🇷France nod_ Lille
can someone reup a path that applies or better yet a MR?
thx
- First commit to issue fork.
- 🇮🇳India sakthi_dev
The mentioned lines are removed. Is the change really required.
- Status changed to Needs review
10 months ago 11:34am 26 February 2024 - Status changed to RTBC
10 months ago 2:53pm 26 February 2024 - 🇺🇸United States smustgrave
Patch https://www.drupal.org/files/issues/2023-08-16/3377198-6.patch → copied into the MR.
- Status changed to Fixed
10 months ago 8:51pm 26 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.