๐Ÿ‡ฎ๐Ÿ‡ณIndia @karanpagare

Account created on 25 January 2022, over 2 years ago
  • Associate Engineer - Fullstack at QED42ย 
#

Merge Requests

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Deprecated the config() method.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

karanpagare โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Addded the change as per #17 but i think we may need to fix php standards for that as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Change looks good to me . Moving to RTBC for now as per issue description..

Though if further change is needed we can also change FieldWidget->LinkWidget.php which also has same issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

The previous destination IDs. This parameter represents the values from the migrate map for the destination entity if this source has previously been migrated already. It is empty the first time you migrate a source row, and contains the map's destination ID values on a subsequent update

The above has been added and looks good to me. Changing to needs review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Changes are as per the proposed resolution. Needs further review from @andypost.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Updated as per @nod_ to use px instead of rem. Rest can be reviewed by Olivero maintainers as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Updated getComponentNames as per #9, can review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

I can see more references also in locale.bulk.inc and locale.module which can be changed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Updated as per @smustgrave comments, can review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Adding patch as per #40

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Updated MR as per latest comments , can review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

karanpagare โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Tested MR !2 , screenshot looks better now and fills screen.
Making RTBC for now.

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Tried using MR!10, but can't seem to get it working. Getting following error:

Checking patch js/modal_blocks.js...
Checking patch src/Plugin/Block/ModalBlock.php...
Checking patch README.md...
Checking patch modal_blocks.module...
Checking patch src/Plugin/Block/ModalBlock.php...
error: while searching for:
      case 'hour':
        $time = 1 * 60 * 60 * 1000;
        break;
      case 'day':
        $time = 1 * 24 * 60 * 60 * 1000;
        break;
      case 'week':
        $time = 7 * 24 * 60 * 60 * 1000;
        break;
      case 'month':
        $time = 30 * 24 * 60 * 60 * 1000;
        break;

error: patch failed: src/Plugin/Block/ModalBlock.php:107
error: src/Plugin/Block/ModalBlock.php: patch does not apply
Checking patch src/Plugin/Block/ModalBlock.php...
error: while searching for:
 *  package
 * )
 */
class ModalBlock extends BlockBase implements BlockPluginInterface
{

    /**
     * {@inheritdoc}
     */
    public function blockForm($form, FormStateInterface $form_state)
    {
        $form = parent::blockForm($form, $form_state);
        $config = $this->getConfiguration();

        $form['block'] = [
        '#type' => 'entity_autocomplete',
        '#title' => $this->t('Block to embed'),
        '#description' => $this->t('Select which block should be embedded inside modal block.'),
        '#target_type' => 'block',
        '#required' => true,
        ];

        $form['period'] = [
        '#type' => 'select',
        '#title' => $this->t('Frequency period type'),
        '#description' => $this->t('Select which period type goes with the frequency value above.'),
        '#empty_option' => $this->t('- Select period type -'),
        '#options' => [
        'hour' => $this->t('Hour'),
        'day' => $this->t('Day'),
        'week' => $this->t('Week'),
        'month' => $this->t('Month'),
        ],
        '#default_value' => $config['period'] ?? 'day',
        '#required' => true,
        ];

        $form['frequency'] = [
        '#type' => 'number',
        '#title' => $this->t('Frequency'),
        '#description' => $this->t('The frequency in which the modal block will appear. You can configure the frequency period below.'),
        '#min' => 0,
        '#default_value' => $config['frequency'] ?? '',
        '#required' => true,
        ];

        $rand = 'modal-block-' . rand(100000, 999999);
        $form['random'] = [
        '#type' => 'hidden',
        '#value' => $config['random'] ?? $rand,
        ];

<<<<<<< HEAD
    return $form;
  }

  /**
   * {@inheritdoc}
   */
  public function blockSubmit($form, FormStateInterface $form_state) {
    $this->setConfigurationValue('block', $form_state->getValue('block'));
    $this->setConfigurationValue('frequency', $form_state->getValue('frequency'));
    $this->setConfigurationValue('period', $form_state->getValue('period'));
    $this->setConfigurationValue('random', $form_state->getValue('random'));
  }

  /**

error: patch failed: src/Plugin/Block/ModalBlock.php:17
error: src/Plugin/Block/ModalBlock.php: patch does not apply
Checking patch modal_blocks.module...
error: while searching for:
<?php

/*
 * @file
 * Provides a Modal Block.
 */

error: patch failed: modal_blocks.module:1
error: modal_blocks.module: patch does not apply
Checking patch src/Plugin/Block/ModalBlock.php...
error: while searching for:
      case 'hour':
        $time = 1 * 60 * 60 * 1000;
        break;
      case 'day':
        $time = 1 * 24 * 60 * 60 * 1000;
        break;
      case 'week':
        $time = 7 * 24 * 60 * 60 * 1000;
        break;
      case 'month':
        $time = 30 * 24 * 60 * 60 * 1000;
        break;

error: patch failed: src/Plugin/Block/ModalBlock.php:107
error: src/Plugin/Block/ModalBlock.php: patch does not apply
Checking patch README.md...
๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Tested #3 , changes are as per https://www.drupal.org/node/3180429 โ†’
Looks fine to me, Parameter description is changed

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Tested Patch #12 , Looks fine to me , which fixes phpcs issues as per command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig swiper_formatter/

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

Not facing these issues on Latest release gin 8.x-3.0-rc9

๐Ÿ‡ฎ๐Ÿ‡ณIndia karanpagare

was still facing an issue with offset from #2 patch, changing it worked.

Production build 0.69.0 2024