External link help text should give an https example instead of http

Apologies - I appear to have committed to the main repository instead of a new branch!

Updated the description of $element['uri']['#description'] as well. The description was also using http://example.com, converted it to HTTPS,

Query: Found the same issue in code comments should we create another issue for them or resolve it under the same issue?

Moving the issue to needs review, Please review and inform if any other changes are required.

Change looks good to me . Moving to RTBC for now as per issue description..

Though if further change is needed we can also change FieldWidget->LinkWidget.php which also has same issue.

There is also another http:// reference in web/core/modules/link/src/Plugin/Field/FieldType/LinkItem.php - this is non-exposed to the user though, but should be worth a consideration.

There are a lot of uses of http:// in the tests as well, but as there is no strict requirement on using https this is not a problem.

LinkFieldUITest needs updating to expect the new URL.

Changes made in:

core/modules/link/src/Plugin/Field/FieldType/LinkItem.php
core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
core/modules/link/tests/src/Functional/LinkFieldUITest.php

Setting to Needs Review

smustgrave → changed the visibility of the branch 3427500-11.x to hidden.

smustgrave → changed the visibility of the branch 11.x to hidden.

Cleaned up the old MRs

Updated the issue summary that core/modules/link/src/Plugin/Field/FieldType/LinkItem.php was also updated

Committed and pushed fd32349c97 to 11.x and 2e5d615345 to 10.3.x. Thanks!

longwave → closed merge request !7025

Automatically closed - issue fixed for 2 weeks with no activity.