- Issue created by @andypost
- Assigned to ankitv18
- Status changed to Active
over 1 year ago 9:51pm 12 March 2023 - ๐ญ๐บHungary Gรกbor Hojtsy Hungary
Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-... โ
- First commit to issue fork.
- Assigned to samit.310@gmail.com
- Status changed to Needs work
8 months ago 9:37am 6 March 2024 - Issue was unassigned.
- Status changed to Needs review
8 months ago 5:21am 7 March 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
HI,
Deprecated code from \Drupal\Core\Url has been removed. Please review.
Thanks
Samit K. - Status changed to Needs work
8 months ago 5:24am 7 March 2024 The Needs Review Queue Bot โ tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request โ . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- Merge request !69503343153: remove deprecated code from \Drupal\Core\Url โ (Open) created by samit.310@gmail.com
- Status changed to Needs review
8 months ago 6:46am 7 March 2024 - ๐ฎ๐ณIndia samit.310@gmail.com
Merge requests is created.
https://git.drupalcode.org/project/drupal/-/merge_requests/6950
Thanks
Samit K. - Status changed to Needs work
8 months ago 7:27am 7 March 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Needs review
8 months ago 8:15am 7 March 2024 - ๐ฎ๐ณIndia karanpagare
Changes are as per the proposed resolution. Needs further review from @andypost.
- Status changed to RTBC
8 months ago 2:36pm 14 March 2024 - ๐บ๐ธUnited States smustgrave
All deprecated code from this file has been removed
- Status changed to Needs work
8 months ago 5:48pm 14 March 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
We never discussed the removal of \Drupal\Core\Url::trustedCallbacks() as per the issue summary.
Can we get a follow-up to remove the method and the interface from this class - then we can proceed here and discuss that on another issue.
- Status changed to RTBC
7 months ago 6:51pm 22 April 2024 - ๐บ๐ธUnited States smustgrave
Opened ๐ Discuss removal of \Drupal\Core\Url::trustedCallbacks() Active
- Status changed to Fixed
7 months ago 8:22pm 22 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.