Fix spelling for words used once, beginning with 'n' -> 'p', inclusive

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

#22 no longer applied with
error: patch failed: core/lib/Drupal/Core/Database/StatementPrefetch.php:3
error: core/lib/Drupal/Core/Database/StatementPrefetch.php: patch does not apply

Mostly looking good, but a few problems remain:

1. +++ b/core/lib/Drupal/Core/Config/ConfigFactoryOverrideInterface.php
   @@ -36,7 +36,7 @@ public function getCacheSuffix();
   -   * and synchronization to use the overrider's implementation of
   +   * and synchronization to use the overriding _____'s implementation of
   

   Uhhh, @xjm was suggesting we fill this in with the right noun, not leave a bunch of blanks in the comment. 😂

   That said, given the rest of the comment, I'm not sure the suggestion is the way to go. I honestly think "overrider's implementation" makes the most sense, unless we completely rewrite this entire comment.

2. +++ b/core/lib/Drupal/Core/Database/StatementPrefetch.php
   @@ -8,7 +8,7 @@
   + * An implementation of StatementInterface that will pre-fetches all data.
   

   "that will pre-fetches all data." isn't grammatically correct.

   Either needs:

   "that will pre-fetch ..."
   or
   "that pre-fetches ..."
   but not both.

3. +++ b/core/lib/Drupal/Core/Routing/RoutePreloader.php
   @@ -11,7 +11,7 @@
   + * Defines a class that can pre-loads non-admin routes.
   

   Also not right.
   "that can pre-load ..."

Addressing #26

Think a file or two may be missing.

Hard to tell as the interdiff is the same as the patch.

I checked the patches (#25 and #27) and they are the same except the interdiff attached here.

Thanks!

Committed/pushed to 10.1.x, thanks!

Discovered while working on 🐛 Fix spellcheck:make-drupal-dict Fixed that this has introduced an error in the dictionary.txt file.

+++ b/core/misc/cspell/dictionary.txt
@@ -839,16 +831,11 @@ outdent
-overrider's

This was removed from the dictionary but the word remains in the code base.

So, what needs to happen it to apply the patch and then run cd core; yarn spellcheck:drupal-make-dict to make sure the dictionary is correct. See https://www.drupal.org/docs/develop/development-tools/cspell →

I've run this command but it throwing error with the command failed and my dictionary got blanked.

@Vidushi Mehta, what was the error?

I rerolled the patch. The only conflict was dictionary.txt

I also removed the removal of 'postbar' because that one of four similar constants defined in \Drupal\Tests\Component\EventDispatcher\ContainerAwareEventDispatcherTest all of which are in the dictionary. I think that should be done in another spelling issue because the other constants are used more than once, which is outside the scope of this issue.

Update word list in the IS.

Applied #37 and ran spellcheck:make-drupal-dict and didn't get any additional changes.

@quietone, The reason for the error was that Windows uses a different syntax for setting environment variables compared to Unix-based systems, The LC_ALL environment variable is specific to Unix-based systems, and it is not recognized in the same way on Windows which throws an error and its forcefully removing the content from the dictionary.txt file.

Working fine on Linux RTBC+1

Thanks for the reroll

Committed 031f63e and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.