readonly state is not visually indicated

Created on 30 May 2023, over 1 year ago
Updated 2 June 2023, over 1 year ago

Problem/Motivation

By fixing 🐛 Readonly doesn't work on #States Fixed there is a lack of the visually indication if a field is readonly.
I think we should use the disabled state or introduce a new visual guide.

Steps to reproduce

Add readonly to any textfield nothing change

Proposed resolution

Add a new css selector for apply disabled to readonly style.

.form-element[disabled],
.form-element[readonly]

Remaining tasks

User interface changes

Supporting readonly state along with disabeld state by indicating the user there is something special with the field like no editing possibility.

API changes

-

Data model changes

-

Release notes snippet

-

Feature request
Status

Postponed: needs info

Version

10.1

Component
Claro 

Last updated 1 day ago

Created by

🇩🇪Germany sunlix Wesel

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @sunlix
  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    29,400 pass
  • 🇮🇳India Vidushi Mehta

    Added a patch for the same

  • 🇮🇳India ravi kant Jaipur

    The patch is working but we do not need this patch because the webform providing style already for readonly and disabled type filed. Attaching screenshot for more clarification.

  • Status changed to Needs work over 1 year ago
  • 🇺🇸United States smustgrave

    before/after screenshots should be added to the issue summary.

    @ravi kant is that class coming from a contrib module?

  • 🇮🇳India mukeysh

    in #3 @ravi kant mentioned web form provides the default state for read-only and disabled but this CSS comes from the webform module which is the contrib module.

    We need ready-only styling in the claro theme as well.

  • 🇮🇳India zeeshan_khan

    @Mukeysh - make sense!
    Added code with before/after png

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Build Successful
  • Status changed to Postponed: needs info over 1 year ago
  • 🇫🇮Finland lauriii Finland

    I don't think we should be applying the disabled styles either because disabled elements are not the same as readonly. The styles for disabled elements have been designed for that specific use case.

    Are there convention to how read only fields should be styled? I checked some common design systems like Bootstrap and it looks like they also don't style the readonly fields.

Production build 0.71.5 2024