- Issue created by @sunlix
- Status changed to Needs review
over 1 year ago 8:03am 1 June 2023 - last update
over 1 year ago 29,400 pass - 🇮🇳India ravi kant Jaipur
The patch is working but we do not need this patch because the webform providing style already for readonly and disabled type filed. Attaching screenshot for more clarification.
- Status changed to Needs work
over 1 year ago 2:02pm 1 June 2023 - 🇺🇸United States smustgrave
before/after screenshots should be added to the issue summary.
@ravi kant is that class coming from a contrib module?
- 🇮🇳India mukeysh
in #3 @ravi kant mentioned web form provides the default state for read-only and disabled but this CSS comes from the webform module which is the contrib module.
We need ready-only styling in the claro theme as well.
- 🇮🇳India zeeshan_khan
@Mukeysh - make sense!
Added code with before/after png - Status changed to Needs review
over 1 year ago 9:12am 2 June 2023 - last update
over 1 year ago Build Successful - Status changed to Postponed: needs info
over 1 year ago 12:04pm 2 June 2023 - 🇫🇮Finland lauriii Finland
I don't think we should be applying the disabled styles either because disabled elements are not the same as readonly. The styles for disabled elements have been designed for that specific use case.
Are there convention to how read only fields should be styled? I checked some common design systems like Bootstrap and it looks like they also don't style the readonly fields.