Admin Toolbar padding issue

Created on 22 June 2023, over 1 year ago
Updated 14 July 2023, over 1 year ago

The right padding is not enough when using Admin Toolbar with Gin theme.

🐛 Bug report
Status

Fixed

Component

User interface

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @LoranRendel
  • 🇮🇳India mukeysh

    Applying a patch to fix the above issue. Also attaching a screenshot for reference.

  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • 🇮🇳India Vidushi Mehta

    @Mukeysh tested your patch, this issue is still not resolved. Added screenshot for the same.

  • 🇮🇳India lokeshsahu Delhi

    I tried to reproduce and fix the above-addressed issue with the help of the #2 patch. The patch was applied successfully without throwing any error but the issue still exists as the patch only has the changes in the source file (SCSS) and no changes on the destination file (CSS). Attaching a screenshot after applying the patch for reference. Issue still exists.

  • 🇮🇳India Vidushi Mehta

    @lokeshsahu, to check this you need to run 'npm run dev' after applying the patch in local, then the change in scss file will reflect.

  • Status changed to Needs review over 1 year ago
  • 🇮🇳India lokeshsahu Delhi

    I have created another patch to address the above issue as the #1 patch couldn't fix the raised issue. I am attaching a screenshot for reference, showing the state before and after applying the patch and a interdiff file for reference.

  • 🇮🇳India mukeysh

    The above patch working fine but only for the Legacy, Classic Drupal Toolbar not for the Horizontal, Modern Toolbar. Also, there is also some issue with the tablet screen. Attaching a screenshot for reference.

    Adding patch with changes.

  • Status changed to RTBC over 1 year ago
  • 🇮🇳India Vidushi Mehta

    I've reviewed both the patches ( #7 and #8 ) and verified that #8 resolved the issue. Added the screenshots of after applying both the patches for more clarity.

  • Status changed to Fixed over 1 year ago
  • 🇨🇭Switzerland saschaeggi Zurich

    Thanks y'all!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024