- 🇺🇸United States smustgrave
Moving to NW for the change record.
This doesn't require any kind of test?
- 🇬🇧United Kingdom longwave UK
I think this could have a test that relies on the context being the
<html>element, this will avoid us breaking this functionality again in the future. - 🇬🇧United Kingdom alexpott 🇪🇺🌍
+++ b/core/misc/drupal.js --- a/core/modules/big_pipe/js/big_pipe.js +++ b/core/modules/big_pipe/js/big_pipe.js +++ b/core/modules/big_pipe/js/big_pipe.js @@ -115,7 +115,7 @@ // Attach behaviors early, if possible. - Drupal.attachBehaviors(document.body); + Drupal.attachBehaviors(document.documentElement); // If loaded asynchronously there might already be replacement elements // in the DOM before the mutation observer is started.Should we also change the observer to attach to document.documentElement for consistency?
Below this code we do...
// Start observing the body element for new children. observer.observe(document.body, { childList: true }); - 🇬🇧United Kingdom longwave UK
Re #21 will anything get added to
<html>but outside of<body>? - Status changed to Needs review
over 1 year ago 9:41am 3 April 2023 - 🇮🇳India Vidushi Mehta
#18 was not applying on big_pipe.js with the latest pull so rerolled the patch with #21 comment.
The last submitted patch, 23: 3160052-22.patch, failed testing. View results →
- last update
10 months ago Patch Failed to Apply