Allow WebP quality to be configurable in GD2 image manipulation toolkit settings

Re rolling patch #11 for 9.5.x.

Hard to get the diff without interdiff ☹️

Reroll of #11 for 9.5.x and 10.1.x

Reroll #11 against 9.5.x and 10.1.x once more (#16 rerolled against older versions of those branches).

The last submitted patch, 16: core-webp_quality_config-3320689-9.5.x.patch, failed testing. View results →

The last submitted patch, 17: core-webp_quality_config-3320689-9.5.x.patch, failed testing. View results →

The last submitted patch, 17: core-webp_quality_config-3320689-10.1.x.patch, failed testing. View results →

I think instead of configuration for each format core can introduce new common option

Also tests needs to be fixed

Patch for 10.2.x.

Patch for 10.2.x.

Patch for 10.2.x.

#23 works fine for me. Thanks for this great patch. Hope this functionnality will be add un future release of Drupal....

Note, this will not retain a color profile. If an image was saved out with Adobe RGB profile, it will be removed on webp conversion with image styles.

#23 works fine for me too. Thanks!

I can confirm that MR #30 works fine for Drupal 10.3.0. Thank you!

Created a patch for 10.2.x as well.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Re-rolled patch for 10.3.x

Still appears to need upgrade path. Also any fixes please put into an MR.

Re-roll #36 for 10.2.4

- Added upgrade path and tests for it.
- Changed the UI facing texts from "WEBP" to "WebP".
- Since Drupal 11 requires PHP 8.3, there's no need to check for support of IMG_WEBP_LOSSLESS
- Hide the outdated patches.

UI changes should be documented in the summary so tagging for that.

Once issue summary is complete will probably need usability sign off for the new UI.

Also change would need a change record

I assume usability review could think following issues:
- Position of lossless checkbox on form.
- Need for lossless checkbox on form. Since the IMG_WEBP_LOSSLESS equals to 101 value ( see: https://php.watch/versions/8.1/gd-webp-lossless). We could remove the checkbox and treat the 100 selection same as lossless selection (This is how Intervention/image does it)

Usability review

We discussed this issue at 📌 Drupal Usability Meeting 2024-09-20 Needs work . That issue will have a link to a recording of the meeting. For the record, the attendees at last Friday's usability meeting were @AaronMcHale, @anmolgoyal74, @benjifisher, @rkoller, @shaal, @simohell, and @zetagraph.

If you want more feedback from the usability team, a good way to reach out is in the #ux channel in Slack.

Recommendations

Use radio-buttons to show both the options as equal choices. This will be clearer for the user and there even is an edge case, where a Safari browser supports lossy format but not lossless. Label them “WebP quality” to match JPEG quality as equal section.

WebP quality
- Lossless compression
- Lossy compression

As "Lossy compression" is selected display the numeric field indented visually to the same level with the radio-button.

WebP quality
- Lossless compression
- Lossy compression
[ 75% ] Set the image quality for WebP manipulations. Ranges from 0 to 100. Higher values mean better image quality but bigger files.

The label text is a suggestion, it was not decided by consensus in the meetiong.

It is also suggested to change the word “define” to “set” in the compression settings description.

Updating documentation

Include the information about WebP setting into documentation at https://www.drupal.org/docs/7/core/modules/image/working-with-images#s-s... →

Add a note, that in some old browsers or operating systems versions it may be, that a browser supports the lossy compression but not the lossless compression.

Thanks usability team!