The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India ranjith_kumar_k_u Kerala
#26 failed to apply on 10.1.x
error: patch failed: core/modules/system/tests/src/Functional/System/FrontPageTest.php:30
error: core/modules/system/tests/src/Functional/System/FrontPageTest.php: patch does not apply - Status changed to Needs review
almost 2 years ago 5:26am 11 April 2023 - Status changed to Needs work
almost 2 years ago 6:28am 11 April 2023 - 🇳🇱Netherlands Lendude Amsterdam
+++ b/core/modules/system/tests/src/Functional/System/FrontPageTest.php @@ -37,10 +38,15 @@ protected function setUp(): void { + try { ... + catch (EntityStorageException $e) { + watchdog_exception('system', $e, 'An error occurred while creating admin user, log in admin user, and create one node'); + }
Don't try/catch in a test, if something fails, the test fails as it should
- 🇮🇳India sahil.goyal
addressed the comment #31 as removing try/catch can ensure that any errors or exceptions that occur during the call, properly reported as test failures, as they should be.
- Status changed to Needs review
almost 2 years ago 5:35am 12 April 2023 - Status changed to RTBC
almost 2 years ago 1:49pm 12 April 2023 - 🇺🇸United States smustgrave
Change looks fine.
Question for committer do we want to do any kind of update hook to set this value or would that be disruptive.
- last update
almost 2 years ago 30,126 pass - last update
almost 2 years ago 30,126 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
almost 2 years ago Waiting for branch to pass - last update
almost 2 years ago 30,126 pass - 🇬🇧United Kingdom catch
I don't think we should have an update hook, it'd be an unexpected change on existing sites. Tagging this for product manager review since it changes the output for the standard profile.
- last update
almost 2 years ago 30,126 pass - last update
over 1 year ago 30,126 pass - Status changed to Needs work
over 1 year ago 8:41am 8 May 2023 - 🇫🇮Finland lauriii Finland
This might help with #2514794: Frontpage view is confusing when only one node is promoted to the default front page → .
However, I'm not personally convinced that we should add "Home" as a heading on the front page. It's not a common practice for real sites, and I believe everyone would need to remove the title from the view to become useful. I think we should try to come up with an alternative solution to this problem.