- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
WIP: This would filter comments per language.
If we have a thread, and the root comment is not translated but the responses are, there are weird identations as the first won't be shown.
It would be great checking how D7 worked in that scenario.Scenario: node translated in English and Spanish
Add comment 1. in English
Add comment 1.1 in Spanish
Add comment 2 in English
Translate comment 2 to Spanish
Add comment 3 in SpanishIn English I should see:
1
2In Spanish I should see:
1.2? Not sure. Also not sure if it's good enough if it has the wrong identation as probably it's not a very common scenario.
2
3 - 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Accidentally uploaded empty patch.
- Status changed to Needs work
over 1 year ago 10:29am 6 April 2023 - 🇮🇳India sahil.goyal
Fixing a minor CCF error to make #29 pass the test.
- Status changed to Needs review
over 1 year ago 11:53am 6 April 2023 - Status changed to Needs work
over 1 year ago 5:05pm 6 April 2023 - 🇺🇸United States smustgrave
Since this is adding a new configuration option it will need an upgrade path for existing sites. With test coverage.
- 🇪🇸Spain penyaskito Seville 💃, Spain 🇪🇸, UTC+2 🇪🇺
Next step is not adding tests or upgrade path, but decide if this is something we want to do and if patch at #28 is good enough.
A screenshot of how does it look in D7 when we have an scenario like the described in #28 would be helpful.
I'll attach screenshots of how it looks like in D10.1 with that patch if noone beats me to do it.
- 🇺🇸United States smustgrave
Gotcha
Never put thought into it but wonder how most sites (non Drupal) handle comments in different languages.
If an article is posted wouldn’t someone like to see all comments vs maybe the comments just in my language.
But can see the other side of if majority of comments are in another language may not be useful.
Just thinking out loud