Automated Drupal 10 compatibility fixes

Hi, any plan for a D10 release? This could be a blocker for many projects. Thanks!

Adding a patch updating the info.yml file.

Updated #6 so tests pass in Drupal 9.5.

Thanx @jedihe for the patch, changes looks alright, and functionality works as expected by applying #7 on Drupal 10.1.x. Moving to RTBC, Please revert back if needed.

As for running the tests in D10, I was able to confirm they all pass doing this:

Initial setup:

composer create-project drupal/recommended-project:^10 d10
cd d10
composer require mglaman/composer-drupal-lenient cweagans/composer-patches -n
composer config "allow-plugins.mglaman/composer-drupal-lenient" true -n
composer config "allow-plugins.cweagans/composer-patches" true -n
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/dfp"]'
composer require drupal/dfp
composer config --merge --json "extra.patches.drupal/dfp" '{"Drupal 10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch"}'                                                                                                                                                           
composer i
composer require drupal/core-dev:^10 phpspec/prophecy-phpunit:^2 --dev
php -S 127.0.0.1:8080 -t web &
SIMPLETEST_BASE_URL=http://127.0.0.1:8080 SIMPLETEST_DB=sqlite://localhost//dev/shm/tmp.sql vendor/bin/phpunit -c web/core web/modules/contrib/dfp/

In case it helps somebody: here's a set of patches to considerably improve DFP:

{
    "extra": {
        "patches": {
            "drupal/dfp": {
                "D10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch",
                "Support sync/async switching": "https://www.drupal.org/files/issues/2023-04-14/dfp-outdated-js-2905298-24--for-3296953-7.patch",
                "Lazy-loading support": "https://www.drupal.org/files/issues/2021-05-21/3179558-dfp-lazyload-8--for-2905298-17.patch",
                "Support out-of-page slots": "https://www.drupal.org/files/issues/2022-05-16/dfp-out-of-page-support-2905255-16.patch",
                "Add slot_id token": "https://www.drupal.org/files/issues/2020-02-25/dfp-slot-id-token-3116037-2.patch",
                "Add token browser": "https://www.drupal.org/files/issues/2021-05-21/dfp-add-token-browser-2905038-9.patch",
                "Multiple ads per ad slot": "https://www.drupal.org/files/issues/2022-05-16/dfp-multiple-ads-per-slot-3116576-9--for-2905298-22--2905255-16.patch",
                "Output JS slot definitions in proper order": "https://www.drupal.org/files/issues/2023-04-14/2837056-dfp-slot-js-definitions-reversed-9.patch"
            }   
        }
    }
}

DFP 1.2 + this patches currently pass tests both for D9.5 and D10.

Code added as a separate branch.
Thanks everyone for contributing. 🍻
Please test 🙏

VladimirAus → closed merge request !6

Automatically closed - issue fixed for 2 weeks with no activity.

I'm sorry to read so late right now, I think that there's nothing left to do now..