Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, almost 2 years ago
Updated 20 September 2023, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇫🇷France FMB Perpinyà, Catalonia, EU

    Hi, any plan for a D10 release? This could be a blocker for many projects. Thanks!

  • Comment over 1 year ago →
    🇪🇨Ecuador afsch Otavalo

    Adding a patch updating the info.yml file.

  • Comment about 1 year ago →
    🇨🇴Colombia jedihe

    Updated #6 so tests pass in Drupal 9.5.

  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India sahil.goyal

    Thanx @jedihe for the patch, changes looks alright, and functionality works as expected by applying #7 on Drupal 10.1.x. Moving to RTBC, Please revert back if needed.

  • Comment about 1 year ago →
    🇨🇴Colombia jedihe

    As for running the tests in D10, I was able to confirm they all pass doing this:

    Initial setup:

    composer create-project drupal/recommended-project:^10 d10
cd d10
composer require mglaman/composer-drupal-lenient cweagans/composer-patches -n
composer config "allow-plugins.mglaman/composer-drupal-lenient" true -n
composer config "allow-plugins.cweagans/composer-patches" true -n
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/dfp"]'
composer require drupal/dfp
composer config --merge --json "extra.patches.drupal/dfp" '{"Drupal 10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch"}'                                                                                                                                                           
composer i
composer require drupal/core-dev:^10 phpspec/prophecy-phpunit:^2 --dev
php -S 127.0.0.1:8080 -t web &
SIMPLETEST_BASE_URL=http://127.0.0.1:8080 SIMPLETEST_DB=sqlite://localhost//dev/shm/tmp.sql vendor/bin/phpunit -c web/core web/modules/contrib/dfp/
  • Comment about 1 year ago →
    🇨🇴Colombia jedihe
  • Comment about 1 year ago →
    🇨🇴Colombia jedihe

    In case it helps somebody: here's a set of patches to considerably improve DFP:

    {
    "extra": {
        "patches": {
            "drupal/dfp": {
                "D10 compatibility": "https://www.drupal.org/files/issues/2023-04-13/3296953-dfp-d10-7.patch",
                "Support sync/async switching": "https://www.drupal.org/files/issues/2023-04-14/dfp-outdated-js-2905298-24--for-3296953-7.patch",
                "Lazy-loading support": "https://www.drupal.org/files/issues/2021-05-21/3179558-dfp-lazyload-8--for-2905298-17.patch",
                "Support out-of-page slots": "https://www.drupal.org/files/issues/2022-05-16/dfp-out-of-page-support-2905255-16.patch",
                "Add slot_id token": "https://www.drupal.org/files/issues/2020-02-25/dfp-slot-id-token-3116037-2.patch",
                "Add token browser": "https://www.drupal.org/files/issues/2021-05-21/dfp-add-token-browser-2905038-9.patch",
                "Multiple ads per ad slot": "https://www.drupal.org/files/issues/2022-05-16/dfp-multiple-ads-per-slot-3116576-9--for-2905298-22--2905255-16.patch",
                "Output JS slot definitions in proper order": "https://www.drupal.org/files/issues/2023-04-14/2837056-dfp-slot-js-definitions-reversed-9.patch"
            }   
        }
    }
}

    DFP 1.2 + this patches currently pass tests both for D9.5 and D10.

  • First commit to issue fork.
  • @aleix opened merge request.
  • Comment 10 months ago →
    System Message
  • Comment 10 months ago →
    🇦🇺Australia VladimirAus Brisbane, Australia

    Code added as a separate branch.
    Thanks everyone for contributing. 🍻
    Please test 🙏

  • Status changed to Fixed 10 months ago
  • Comment 10 months ago →
    System Message
  • Comment 10 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed 9 months ago
  • Comment 9 months ago →
    🇪🇸Spain aleix

    I'm sorry to read so late right now, I think that there's nothing left to do now..

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024