- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:34pm 20 April 2023 - Status changed to Needs work
over 1 year ago 5:51am 21 April 2023 - ๐ต๐ญPhilippines paraderojether
I reviewed patch #2 and there are still remaining errors/warnings.
FILE: ...udenttrainees/Drupal2/drupalsite/docroot/modules/contrib/anonymous_timezone/src/Form/AnonymousTimezoneSettingsForm.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------------------------
19 | ERROR | Missing short description in doc comment
24 | ERROR | Missing short description in doc comment
80 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
94 | ERROR | join() is a function name alias, use implode() instead
113 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------FILE: ...rs/studenttrainees/Drupal2/drupalsite/docroot/modules/contrib/anonymous_timezone/src/AnonymousTimezoneAccountProxy.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
47 | ERROR | [ ] Parameter $cache is not described in comment
123 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------Please revise.
Thank You. - Status changed to Needs review
over 1 year ago 7:29am 21 April 2023 - ๐ฎ๐ณIndia sahil.goyal
sahil.goyal โ made their first commit to this issueโs fork.
- @sahilgoyal opened merge request.
- Status changed to RTBC
over 1 year ago 12:16pm 21 April 2023 - Status changed to Fixed
over 1 year ago 7:06am 24 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.