Move DateTimeItem and DateRangeItem constants onto interfaces.

Was tagged for change record updates. Maybe this needs it's own now.

Draft CR Created.

Line core/modules/datetime/tests/src/Kernel/Views/DateTimeHandlerTestBase.php
------ ----------------------------------------------------------------------------------
72 Access to an undefined static property
static(Drupal\Tests\datetime\Kernel\Views\DateTimeHandlerTestBase)::$field_type.
------ ----------------------------------------------------------------------------------

------ -------------------------------------------------------------------------
Line core/modules/datetime/tests/src/Kernel/Views/FilterDateTest.php
------ -------------------------------------------------------------------------
53 Access to an undefined static property
static(Drupal\Tests\datetime\Kernel\Views\FilterDateTest)::$field_name.
------ -------------------------------------------------------------------------

------ -------------------------------------------------------------------------------
Line core/modules/datetime_range/tests/src/Kernel/Views/FilterDateTest.php
------ -------------------------------------------------------------------------------
60 Access to an undefined static property
static(Drupal\Tests\datetime_range\Kernel\Views\FilterDateTest)::$field_name.

sahil.goyal → made their first commit to this issue’s fork.

Addressed the CCF error as described in #86.

@sahil.goyal changes to variable name format should be in other way around.

Moving to NW for failures in the MR.

Searching for DateTimeItem:: still see there are about 30+ instances remaining.

Please review.

Will let the committers decide but there are still some instances of DateTimeItem:: but they are in comments for some. Should these be updated too? Didn't think it was worth holding up the ticket.

  /**
   * Tests DateTimeItem::setValue().
   */

grep -R --color "DateTimeItem::"
./core/modules/jsonapi/tests/src/Functional/JsonApiRegressionTest.php:      'settings' => ['datetime_type' => DateTimeItem::DATETIME_TYPE_DATETIME],
./core/modules/jsonapi/tests/src/Functional/JsonApiRegressionTest.php:      'settings' => ['datetime_type' => DateTimeItem::DATETIME_TYPE_DATE],
./core/modules/jsonapi/tests/src/Functional/JsonApiRegressionTest.php:      'settings' => ['datetime_type' => DateTimeItem::DATETIME_TYPE_DATETIME],
./core/modules/datetime_range/tests/src/Kernel/SeparatorTranslationTest.php:      'settings' => ['datetime_type' => DateTimeItem::DATETIME_TYPE_DATE],
./core/modules/datetime/tests/src/Functional/DateFilterTest.php:      'settings' => ['datetime_type' => DateTimeItem::DATETIME_TYPE_DATETIME],
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:   * Tests DateTimeItem::setValue().
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    // Test DateTimeItem::setValue() using string.
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    $this->assertEquals($value, $entity->field_datetime[0]->value, 'DateTimeItem::setValue() works with string value.');
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    // Test DateTimeItem::setValue() using property array.
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    $this->assertEquals($value, $entity->field_datetime[0]->value, 'DateTimeItem::setValue() works with array value.');
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    // Test DateTimeItem::setValue() using string.
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    $this->assertEquals($value, $entity->field_datetime[0]->value, 'DateTimeItem::setValue() works with string value.');
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    // Test DateTimeItem::setValue() using property array.
./core/modules/datetime/tests/src/Kernel/DateTimeItemTest.php:    $this->assertEquals($value, $entity->field_datetime[0]->value, 'DateTimeItem::setValue() works with array value.');
./core/modules/datetime/src/Plugin/views/filter/Date.php:    if ($definition->getSetting('datetime_type') === DateTimeItem::DATETIME_TYPE_DATE) {
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php: * @see \Drupal\datetime\Plugin\Field\FieldType\DateTimeItem::DATETIME_TYPE_DATE
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:    if ($parent_field_item_class === DateTimeItem::class) {
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:    if ($parent_field_item_class === DateTimeItem::class) {
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:      // @see \Drupal\datetime\Plugin\Field\FieldType\DateTimeItem:DATETIME_TYPE_DATE
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:        DateTimeItem::class,
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:        DateTimeItem::DATETIME_TYPE_DATE,
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:      // @see \Drupal\datetime\Plugin\Field\FieldType\DateTimeItem:DATETIME_TYPE_DATETIME
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:        DateTimeItem::class,
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:        DateTimeItem::DATETIME_TYPE_DATETIME,
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:    $field_definition->getSetting('datetime_type')->willReturn($type === 'date-only' ? DateTimeItem::DATETIME_TYPE_DATE : DateTimeItem::DATETIME_TYPE_DATETIME);
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:    $field_definition->getSetting('datetime_type')->willReturn(DateTimeItem::DATETIME_TYPE_DATE);
./core/modules/serialization/tests/src/Unit/Normalizer/DateTimeIso8601NormalizerTest.php:    $field_definition->getSetting('datetime_type')->willReturn(DateTimeItem::DATETIME_TYPE_DATETIME);
./core/modules/serialization/src/Normalizer/DateTimeIso8601Normalizer.php:    if ($field_item instanceof DateTimeItem && $field_item->getFieldDefinition()->getFieldStorageDefinition()->getSetting('datetime_type') === DateTimeItem::DATETIME_TYPE_DATE) {
./core/modules/serialization/src/Normalizer/DateTimeIso8601Normalizer.php:    $is_date_only = $datetime_type === DateTimeItem::DATETIME_TYPE_DATE;

Please ignore Merge request !2321 ,

Updated Merge request !3013 to replace existing few more instances of "DateTimeItem::"