- Issue created by @joachim
- ๐ฎ๐ณIndia sahil.goyal
sahil.goyal โ made their first commit to this issueโs fork.
- @sahilgoyal opened merge request.
- ๐ฎ๐ณIndia sahil.goyal
I reviewed the code and found that the warning message was generated because the
parse_url()
function may not always return the "scheme" and "host" keys if they are not present in the URL string, so made changes accordingly, Along made a small PHPCS observed error/warning. Thank you. - ๐ฌ๐งUnited Kingdom joachim
Thanks for the MR!
It's against the wrong branch though.
- @sahilgoyal opened merge request.
- ๐ฎ๐ณIndia sahil.goyal
Thanx @joachim for suggestion, "scheme" and "host" keys are depends on url, as scheme not added in zendesk_url would suggest warning if it is undefined, so default domain needed, and as suggested
we just bailed and did nothing if zendesk_url is empty
added condition, Removed PHPCS fix in this MR, Now created MR against correct branch.
- Status changed to Needs review
over 1 year ago 4:24am 27 April 2023