warnings if zendesk_users not yet configured

Created on 12 April 2023, about 1 year ago
Updated 27 April 2023, about 1 year ago

Problem/Motivation

If the zendesk_users module is enabled but not yet configured, user operations that cause the ZendeskUsers to be invoked produce warnings:

 [warning] Undefined array key "scheme" ZendeskUsers.php:82
 [warning] Undefined array key "host" ZendeskUsers.php:82

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

๐Ÿ› Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joachim
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sahil.goyal

    sahil.goyal โ†’ made their first commit to this issueโ€™s fork.

  • @sahilgoyal opened merge request.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sahil.goyal

    I reviewed the code and found that the warning message was generated because the parse_url() function may not always return the "scheme" and "host" keys if they are not present in the URL string, so made changes accordingly, Along made a small PHPCS observed error/warning. Thank you.

  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom joachim

    Thanks for the MR!

    It's against the wrong branch though.

  • @sahilgoyal opened merge request.
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia sahil.goyal

    Thanx @joachim for suggestion, "scheme" and "host" keys are depends on url, as scheme not added in zendesk_url would suggest warning if it is undefined, so default domain needed, and as suggested

    we just bailed and did nothing if zendesk_url is empty

    added condition, Removed PHPCS fix in this MR, Now created MR against correct branch.

  • Status changed to Needs review about 1 year ago
Production build 0.69.0 2024