The last submitted patch, 37: 3182665_37.patch, failed testing. View results โ
- Status changed to RTBC
over 1 year ago 4:34am 13 April 2023 - last update
over 1 year ago 29,202 pass - last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,359 pass - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 12:24pm 1 May 2023 - ๐ณ๐ฟNew Zealand quietone
The patch no longer applies. Tagging for a re-roll.
A reminder to everyone that it helps reviewers to have screenshot available from the Issue Summary. That can the screenshot or a link to the comment with the latest screenshots.
- Status changed to Needs review
over 1 year ago 8:03am 2 May 2023 - last update
over 1 year ago Patch Failed to Apply - ๐ฎ๐ณIndia Santosh_Verma
#quietone i am rerolling the patch for Drupal 10.1.x
- last update
over 1 year ago 29,368 pass - ๐ฎ๐ณIndia Santosh_Verma
#quietone sorry for patch #43
rerolling the patch again for Drupal 10.1.x with interdiff - ๐ฎ๐ณIndia Asha Nair
Could not find this issue in 10.x in Olivero theme. Table headers are aligned according to the view settings without the patch.
- Status changed to Needs work
over 1 year ago 5:32pm 6 May 2023 - ๐บ๐ธUnited States smustgrave
Think before/after screenshots should be added to the issue summary to show this issue.
Thanks.
- Assigned to lokesh jamadar
- Issue was unassigned.
- ๐ฎ๐ณIndia Harish1688 India
As per #47 request,
1. updated the issue image in issue summary. (Align table headers issue.png )
2. After patch (3332049-45.patch) applied, issue resolved adding after screenshot (3182665 after patch 45.png).
- Status changed to Needs review
over 1 year ago 6:51am 20 June 2023 - Status changed to Needs work
over 1 year ago 1:18pm 20 June 2023 - ๐บ๐ธUnited States smustgrave
Before/after screenshots are not in the issue summary.
- Status changed to Needs review
over 1 year ago 7:12am 21 June 2023 - ๐ฎ๐ณIndia Harish1688 India
Hi @smustgrave,
I have updated the images in (#51, #52) but it's not showing via unknown error but added the Before/after screenshots in the issue summary.
- Status changed to Needs work
over 1 year ago 3:46pm 21 June 2023 - ๐บ๐ธUnited States smustgrave
Following the steps in the issue summary with the content view confirmed the issue
Patch #45 did not resolve the issue though. - Status changed to Needs review
over 1 year ago 9:20am 28 June 2023 - last update
over 1 year ago Build Successful - ๐ฎ๐ณIndia Harish1688 India
As per comment #58, Tested the patch #45 again and create a new patch (align-table-headers-3182665-59.patch) with modified some css property.
Note: If no alignment CSS (views-align-left, views-align-center, views-align-right) is defined, the text alignment of the "th" tag will be left-aligned by default.
Needs Review.
- Status changed to Needs work
over 1 year ago 3:28pm 28 June 2023 - ๐บ๐ธUnited States smustgrave
Did not test but last patch caused a number of test failures.
- Status changed to Needs review
over 1 year ago 10:21am 29 June 2023 - ๐ฎ๐ณIndia Harish1688 India
Hi @smustgrave,
the last patch in #59 ( https://www.drupal.org/pift-ci-job/2704056 โ ) is build successfully. so moving to need review.
- Status changed to Needs work
over 1 year ago 12:00pm 29 June 2023 - ๐บ๐ธUnited States smustgrave
If itโs not green it didnโt pass. Means night watch failed or there were so many errors it didnโt output the number