Claro: Form labels that are disabled have too low color contrast

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

This actually appears to have already been fixed. If anyone can confirm we can close this out.

Color contrast is changed and updated after applying MR on 9.5x but it not getting applied to the D10.0.x it still shows old color contrast as color: #828388. i think it needs to be updated..

without applying the patch this isn't fixed at all. i've rechecked with a current install of 10.1.xdev. the media source label still has a color contrast of 3,78:1 (#828388). i have saved me to recheck the rest of the color contrasts. the issue is still relevant and necessary. only problem is the patch doesn't apply anymore with composer patches.

one idea. i am not really a fan of disabled interface elements. they have those a11y implications which were the reason this issue was initially created plus they are potentially confusing from an ux perspective. in the case of the set media type why not drop the greyed out display for disabled select form elements and instead make it an informal badge? i've just chopped it together in devtools. i've just removed the is-disabled classes and switched off the background image for the pointing down arrow.

would definitely need design input but i just wanted to communicate the general gist. the user is unable to make adjustments and is just presented with the media source for the current media type. the description underneath would have to be slightly adjusted. but from my point of view that would fix at least the disabled form media source form elements problems. it would be clear to the user no interaction is necessary, what the media source is and the contrast issues would be avoided.

Patch #13, no longer applies to 10.1.x. I have provided updated patch for same. please review

#22 applied successfully, attaching the screenshot of what I see on 10.1.0-dev

Using a contrast tool the label passes but not the field.

After patch

Here is the results from contrast tool.

Believe this is good

nod_ → closed merge request !7861

Committed and pushed e8298e81ba to 11.x and 22b06e0042 to 11.0.x and 8e344072b3 to 10.4.x and 271a556170 to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.