- Issue created by @rpayanm
- Status changed to Needs review
9 months ago 8:06pm 14 August 2024 - Status changed to Needs work
9 months ago 1:16pm 22 August 2024 - π«π·France Grimreaper France π«π·
Hi,
I am ok with the change and the feature request.
Code quality tools needs to be fixed before merging.
- Assigned to Grimreaper
- π«π·France Grimreaper France π«π·
Please give more details of what is your usage.
PageTop->alter() is just an OOP wrapper around hook before Core had the ability to declare hooks in classes with PHP attribute. So its signature should match the hook one. It is not intended to be reused anywhere in the code.
What can be done is part of PageTop->alter() could be extracted in a service or put directly into the UiSkinsUtility class.