Fullscreen stopped working after update to 1.0.0-beta9

Sourav_Paul → changed the visibility of the branch 3467117-fullscreen-stopped-working to hidden.

Thanks for the quick reply. Unfortunately the problem still exists.

Its working after applying the patch.
Please find the attached SR with it.

I found the problem.
Our users do not have the following permissions.

access toolbar

Without this permission the button no longer works

@carstenhager have you checked? Is it working with or without the patch?

It makes no difference whether you have a patch or not.
It is the permission that causes the error.

Thanks both. And thanks for confirming the issue cause @carstenhager. The toolbar was introduced into the plugin here 🐛 Fullscreen mode interferes with link button Needs review but it slipped past that this would require the toolbar to be required. I'll have to break this down and see about backing out of those changes.

We are using the https://www.drupal.org/project/layout_builder_iframe_modal → module and are having failures for the same reason. The patch adding the dependency on the toolbar library doesn't help though because the the toolbar itself is not loaded within the iframe. So there will be errors that the toolbar library throws like Uncaught TypeError: document.querySelector('#toolbar-administration') is null.

I would recommend making the toolbar optional rather than a hard dependency. Currently, any site not using the toolbar will get errors.

I've added a check for the toolbar to the dev branch that should alleviate this issue - https://www.drupal.org/project/ckeditor5_fullscreen/releases/1.0.x-dev →

If all looks ok, I'll make a new release.

Unfortunately, I get the following error in the dev branch:
Uncaught CKEditorError: getElementById is not defined

@carstenhager I have altered the toolbar check in the dev branch again (properly this time!) and it is working in my tests. If this looks good, I'll go ahead with a new release.

@occupant Thank you for your work. It works for me now too.

Fixed in 1.0.0-beta10