Automated Drupal 11 compatibility fixes for entity_reference_integrity

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

3455209-manual-drupal-11 branch should be ready to go ; needs review.

Tests are passing. Moving to RTBC!

PS: We should probably set up CI so running tests would become easier.

m.stenta → made their first commit to this issue’s fork.

Rebased MR11 onto the new 2.x branch. Some of the changes were already taken care of in 📌 Add .gitlab-ci.yml to run tests and linting Active , so now it's just declaring ^11 support in the *.info.yml files (I amended the commit to add it to the enforce sub-module too, which didn't have core_version_requirement previously.

PS: We should probably set up CI so running tests would become easier.

This is done! 📌 Add .gitlab-ci.yml to run tests and linting Active

So let's see how the tests go...

There's one failing test...

    Enforced Integrity (Drupal\Tests\entity_reference_integrity_enforce\Functional\EnforcedIntegrity)
     ✘ Node integrity
       ┐
       ├ Behat\Mink\Exception\ExpectationException: An element matching css ".form-submit" appears on this page, but it should not.
       │
       │ /builds/project/entity_reference_integrity/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/project/entity_reference_integrity/vendor/behat/mink/src/WebAssert.php:492
       │ /builds/project/entity_reference_integrity/modules/entity_reference_integrity_enforce/tests/src/Functional/EnforcedIntegrityTest.php:84
       │ /builds/project/entity_reference_integrity/modules/entity_reference_integrity_enforce/tests/src/Functional/EnforcedIntegrityTest.php:50
       ┴

Setting this to "Needs work"... I'll see if I can figure out what's going wrong...

It's a caching issue. The /node/1/delete page gets cached after the first time it's accessed (before the reference integrity module configuration is saved), so the second time it's accessed it still shows the "Confirm" submit button. I experienced the same thing testing manually. Notably it still prevents the user from deleting the entity when that happens - it seems to just reload the confirm form and then the expected "You can not delete this as it is being referenced by another entity" message is visible (and the submit button is gone).

This probably means we should be rebuilding the relevant cache when the entity_reference_integrity_enforce.settings form is submitted.

This probably means we should be rebuilding the relevant cache when the entity_reference_integrity_enforce.settings form is submitted.

Correction: I believe the proper approach is to add a cacheable dependency to the entity deletion form that we're altering, so that it is reset when config:entity_reference_integrity_enforce.settings changes.

I pushed a commit. Let's see if tests pass now...

All tests are green! We support Drupal 11 now! :-)

Automatically closed - issue fixed for 2 weeks with no activity.