[upstream] CKEditor 5 PasteFromOffice plugin should not allow MS Office/Apple Pages/Google Docs-specific classes and styles even when HTML is unrestricted

The upstream issue in ckeditor5 is closed due to inactivity

There has been actually work happening in a duplicate of the issue that you mentioned (both were opened by me 🙈) :)

Just last week we resolved https://github.com/ckeditor/ckeditor5/issues/14925. You can test how it works on the nightly docs: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/features/pasti...

Let's test the improved pasting from Word at the demo that @Reinmar provided! 😊🚀

I went to the link provided in #20 and pasted teh example word doc they had and didn't see any issue. But not sure what to really test.

Not sure if this is just marked fixed?

Let's test this in Drupal to make sure it's actually solved.

I will update 🌱 [meta] Test against CKEditor 5 nightly Active shortly, now that 📌 [upstream] Update CKEditor 5 to 40.0.0 Needs review has landed. Once I've done that, manual testing will be much simpler.

I copied the sample Google Doc into the nightly CKE5 textarea posted by Reinmar and still saw the issue:

@pmagunia Thanks! Reported: https://github.com/ckeditor/ckeditor5/issues/14925#issuecomment-1840403697

Can you share what exact browser version you're using? (AFAICT it's Safari on iPad, but I can't tell which version.)

You're welcome Wim. I was using Safari 17.1.2. I did mention that in the Github thread you provided in comment #26

It also seems Word comments are not working elegantly. I tried to upload the docx sample file I used but the file extension is blacklisted.

I was using Safari 17.1.2

TIL https://github.com/ckeditor/ckeditor5/issues/14925 was fixed by https://github.com/ckeditor/ckeditor5/pull/15230, which shipped in https://github.com/ckeditor/ckeditor5/releases/tag/v40.1.0 and hence is already in 10.2.0-RC1!

Can somebody please test this? 😊🙏

Paste from Google doc

Import from word

Styling appears to be preserved (not sure right status for this)

#32: but are still present or not?

Looking at the source code I see just style attributes.

Attaching some screenshots of the source code, can paste the full output if that helps but hate making the ticket super long haha

Paste from Google doc

Import from word

A couple of thoughts, a screenshot from @pmagunia was showing Paste from Office enhanced, a premium offering which job is to keep as many styles as possible. So we literally try to inline everything that makes sense, as users expect to preserve almost 1:1 style relation to copied documents 😱 Styles showed in the screenshot are legit CSS.

Paste from Office (basic plugin) has a bit of a dual nature, on one hand, it deletes the garbage like mso-* classes, on the other, it will try to preserve some very basic styling.

As for the comments, to preserve them elegantly, you would need to have some comment feature. Therefore, we have an integration of Import from Word + Comments, as import prepares a specific markup for our Comments feature to handle.

Hope this helps :)

I think style attributes are not allowed in "Limit HTML" filter.

Doesn't seem that there is anything more for us to do here, given this is fixed upstream and shipped in Drupal 10.2.0 I am marking this as fixed and crediting anyone who moved the discussion along.

Automatically closed - issue fixed for 2 weeks with no activity.