Code improvements in TeaserBehaviorBase

Created on 17 March 2025, 7 months ago

I found two things in abstract class Drupal\openculturas_teaser\Plugin\paragraphs\Behavior that should be improved:

getBaseBuildArray() the potentially expensive function getTeaserMediaId() and then overrides its result with a static value, if that is given. getTeaserMediaId() should only be called if necessary.
In getTeaserMediaId(), a condition on $item['type'] doesn't check if that key exists, resulting in a notice.

📌 Task

Status

Active

Version

2.4

Component

Code

Created by

🇩🇪Germany mrshowerman Munich

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @mrshowerman
Comment 7 months ago →
🇩🇪Germany mrshowerman Munich
Attached patch fixes both issues.
Comment 7 months ago →
🇩🇪Germany tobiasb Berlin
Commited. Rector made oneliner for media id.

tobiasb → committed 3b53de60 on 2.4.x

Issue #3513415 by mrshowerman: Code improvements in TeaserBehaviorBase

Comment 7 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024