Url::createFromRequest ignores query parameters

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rerolled the patch and created the MR

Tried to fix CCF in #2.

The last submitted patch, 18: 2985400-18.patch, failed testing. View results →

Just FYI to help get the message out there.

Starting March 2023, simple rerolls, rebases, or merges will no longer receive issue credit. Only rerolls that address a merge conflict will be credited, and the merge conflict that was resolved must be documented in the text of an issue comment.

Example
error: patch failed: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module:77
error: core/modules/system/tests/modules/twig_theme_test/twig_theme_test.module: patch does not apply

#20 contains all the pieces of the patch @2

Matches the issue summary part to add the query parameter to the URL object.

The last submitted patch, 20: 2985400-19.patch, failed testing. View results →

The patch is applied successfully, but the Test fail due to Layout Builder. Moving the status again RTBC.

Can we please get a change record here, as there is a behaviour change.

I'm half inclined to say we should be adding a second argument to the method here that defaults to false, something like 'bool $withQuery = FALSE' to try to preserve the existing behaviour which some people may be using now.

I'll ask a release manager

Pinged release managers in slack for a second opinion on the possible risk of disruption

larowlan → credited catch → .

Discussed with @catch who felt it was OK to add with a change notice in a minor release.

So NW for a change record/release note snippet

This issue came up as a daily BSI target.

Seems this got the green light, so MR needs to be updated for 11.x and CR written still.

tobiasb → changed the visibility of the branch 2985400-urlcreatefromrequest-ignores-query to hidden.

I created a new MR, because I can change the target branch.