- Issue created by @tmaiochi
- Status changed to Needs review
about 1 year ago 7:59pm 5 September 2023 - 🇧🇷Brazil tmaiochi
I made a patch for use the module in Drupal 10, please review!
- 🇳🇱Netherlands markwittens
Can confirm this patch works, resolves issues reported by the Upgrade status module and PDF's still get generated as expected.
- First commit to issue fork.
- 🇪🇸Spain mabuweb
I have recently updated to Drupal 10, but I can't get the TCPDF module to work.
I've tried to apply the 3367239-2.patch in D9 before updating to D10, but composer failed anyway on the update saying the module is not D10 compatible.I also tried to install the module after after the update to D10:
composer require 'drupal/tcpdf:^2.0' --ignore-platform-reqs --with-all-dependencies
but it returns:Your requirements could not be resolved to an installable set of packages.
Problem 1
- drupal/tcpdf[2.0.0, ..., 2.0.3] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0, ..., 8.9.20, 9.0.0, ..., 9.5.11] but these were not loaded, likely because it conflicts with another require.
- Root composer.json requires drupal/tcpdf ^2.0 -> satisfiable by drupal/tcpdf[2.0.0, 2.0.1, 2.0.2, 2.0.3].Is there any other way to install it in Drupal 10?
Are you planning to publish in the near future a Drupal 10 release of the TCPDF module?Thank you very much for your help!
- 🇪🇸Spain sap60
Hello
I want to migrate to Drupal 10 and I am in the same situation as mabuweb.
I use this module a lot.
Are you planning to release a new Drupal 10 version of the TCPDF module in the near future?Thank you very much for your help!
- Status changed to RTBC
12 months ago 11:00am 6 December 2023 - 🇪🇸Spain budalokko Girona
Patch looks correct and works !! My setup is quite simple, but setting to RTBC as specific issues could be fixed in separate issues.
I could test and working fine:
- Using the "callback" functionality in header via
DrupalInitialize
- Using the "html" functionality in footer viaDrupalInitialize
@mabuweb The following is needed for using and testing in a d10 site and through the upgrade:
- Add the issue fork as an additional repository, and instruct composer to use it for this specific module. Notice the "exclude" key added in first repository, and the entire new repository added for
drupal/tcpdf
"repositories": [ { "type": "composer", "url": "https://packages.drupal.org/8", "exclude": ["drupal/tcpdf"] }, { "type": "package", "package": { "name": "drupal/tcpdf", "type": "drupal-module", "version": "dev-3385155-drupal-10-support", "source": { "type": "git", "url": "https://git.drupalcode.org/issue/tcpdf-3385155", "reference": "3385155-drupal-10-support" } } } ],
- Require this specific version you added:
composer require drupal/tcpdf dev-3385155-drupal-10-support
Once the module maintainers merge this and a new version is available, those changes could be removed.