- Issue created by @Mahendar00279
- Status changed to Postponed: needs info
9 months ago 4:07pm 25 March 2024 Is that the precise type error or have you edited the text? I've not seen "as in class" before.
Also please give the exact versions of Webform and of Devel and list the versions that changed when you, as you put it, migrated. Did you migrate or upgrade?
- ๐ฎ๐ณIndia Mahendar00279
Thank you for your response Cilefen,
I encountered an issue after upgrading from Drupal 10.1 to 10.2.4. I'm using Devel 5.2.1 and Webform 6.2.2. - Status changed to Needs work
9 months ago 12:34pm 4 April 2024 - ๐บ๐ฆUkraine taraskorpach Lutsk ๐บ๐ฆ
I've faced the issue as well. It seems like the 'Devel' maintainers have changed a lot of code in the DevelGenerateBase, while the WebformSubmissionDevelGenerate plugin extends it. Look on the commit.
Webform 6.2.2
Devel 5.2.1 - Status changed to Active
9 months ago 2:05pm 4 April 2024 - First commit to issue fork.
- Merge request !429Issue #3435903: Fix incompatibility with devel ^5.2 โ (Closed) created by jrockowitz
- last update
9 months ago 536 pass - Status changed to Needs review
9 months ago 7:04pm 4 April 2024 - ๐บ๐ธUnited States jrockowitz Brooklyn, NY
The MR attempts to support devel 5.2 and 5.1.
Tested MR#429 and resolves the issue OK for me. I haven't deployed this into a production site, this is just a few basic tests using the email handler (since I didn't experience any problem without this).
A workaround is to uninstall the Devel Generate module (so long as that's not going to impact other functions of your site).
- ๐ฆ๐บAustralia pandaski
We encountered this issue today while trying to update the Devel module to version 5.2.1 from 5.1.2.
We are using Drupal core 10.1.8 and Webform 6.2.2.
- Status changed to RTBC
8 months ago 7:26am 9 April 2024 - ๐บ๐ฆUkraine taraskorpach Lutsk ๐บ๐ฆ
#12 says that the issue is solved with the MR. Setting RTBC because of this.
- Status changed to Needs work
8 months ago 1:50pm 9 April 2024 - ๐บ๐ธUnited States jrockowitz Brooklyn, NY
We need to confirm that the MR does NOT break older versions of the devel module.
- ๐บ๐ธUnited States seoulpanda20
Confirming that I'm also running into this problem. I receive a 500 PHP Fatal error on form submission.
Versions:
- Core: 10.2.5
- Devel: 5.2.1
PHP Fatal error on form-submission:
PHP Fatal error: Type of Drupal\\webform\\Plugin\\DevelGenerate\\WebformSubmissionDevelGenerate::$entityTypeManager must be Drupal\\Core\\Entity\\EntityTypeManagerInterface (as in class Drupal\\devel_generate\\DevelGenerateBase) in /var/www/html/www.example.com/web/modules/contrib/webform/src/Plugin/DevelGenerate/WebformSubmissionDevelGenerate.php
Frustrating but glad I came across this thread!
Thanks for your hard work all these years, @jrockowitz.
- Status changed to RTBC
7 months ago 3:58pm 9 May 2024 - ๐ต๐ฑPoland mscieszka
I can confirm that after installing a fresh Webform 6.2.x and applying the patch from the MR, I can submit the default contact form without the WSOD that occurred when using Devel 5.2.1. Also, after downgrading to 5.1.2 and applying the patch, the form submits correctly.
- ๐ณ๐ฑNetherlands ricovandevin
I can confirm that the patch resolves the issue for Webform 6.2.2 and Devel 5.2.1. Also, things still work after disabling Devel Generate (which should generally be done for production websites).
- ๐บ๐ธUnited States inversed
Confirmed here as well. Either disabling Devel Generate or the patch, both solutions work with Webform 6.2.2 and Devel 5.1.2.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Liam Morland โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
To rely on the base classes dependencies, we might need to change
$instance = new static($configuration, $plugin_id, $plugin_definition);
- to -
$instance = parent::create($container, $configuration, $plugin_id, $plugin_definition);
- Status changed to Needs review
5 months ago 10:46am 31 July 2024 - ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I have made the change suggested in #25. I don't see how it could have worked without this change so full review that this code is working is needed.
- ๐ฎ๐ณIndia gg24
I see that a commit for 10.3 is being added in the same patch where we are handling the issue for dev module incompatibility. IMHO this should have been handled in the separate issue.
Hence, I am re-rolling a patch for 10.2 Drupal version.
Thanks!
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
The Drupal 10.3 commit was added by accident. I have removed it by rebasing.
- Status changed to Needs work
about 2 months ago 4:55pm 22 October 2024 - First commit to issue fork.
- ๐ณ๐ฑNetherlands idebr
This issue was fixed as part of โจ Drupal 11 compatibility fixes for webform Active
It can probably be closed as a duplicate
While this was fixed in โจ Drupal 11 compatibility fixes for webform Active it looks like that only made it to the 6.3 branch. Can we get this into 6.2 please?
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
6.2.x receives only security support and critical bug fixes. It will be EOL very soon.