- Issue created by @eashika
- Status changed to Needs work
10 months ago 8:29pm 16 January 2024 - ๐บ๐ธUnited States markdorison
Thank you for the issue and patch! Before review, it needs to be re-rolled as a merge request so that GitLabCI tests will run against it.
- Issue was unassigned.
- First commit to issue fork.
- Status changed to Needs review
10 months ago 5:00am 17 January 2024 - ๐ฎ๐ณIndia viren18febS
I have created the MR for same patch, please review.
- Status changed to Needs work
10 months ago 5:02pm 17 January 2024 - ๐บ๐ธUnited States markdorison
PHPCS is flagging these additions because
ManageVersionGroup
is not used in those changed files.I noticed that 'use Drupal\quick_node_clone\ManageVersionGroup;' is missing in the following files:
What led you to those specific files as needing the use statements?
- First commit to issue fork.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3415081-error-class-drupalquicknodecloneentitymanageversiongroup to hidden.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3415081-remove-unused to hidden.
- Status changed to Needs review
7 months ago 8:30am 23 April 2024 - Status changed to Needs work
7 months ago 4:20pm 4 May 2024 - ๐บ๐ธUnited States markdorison
I am not seeing any changes in the MR 27 diff. Am I missing something?
- ๐ฎ๐ณIndia samit.310@gmail.com
Hi @markdorison,
Actually when i rebase it with new code that changes all the changes was already there. Following are the changes i pushed with 27 MR.
https://git.drupalcode.org/project/quick_node_clone/-/merge_requests/27/...
I guess we can close this ticket as the issue is already resolved.
Thanks
Samit K. - Status changed to Closed: outdated
6 months ago 4:39am 17 May 2024 - ๐ฎ๐ณIndia gg24
This issue is not reproducible anymore and the class mentioned is not needed to be imported anymore in the mentioned classes. Hence closing this issue. Feel free to reopen the issue if needed.
Thanks!