Deprecate comment_uri()

Updated the issue title, this is just a straightforward deprecation now. Needs a re-roll updating the deprecation version.

Filed CR https://www.drupal.org/node/3384294 →

and updated patch, looks there's no test for uri_callback annotation in comment entity

Also it needs update hook to clear entity definition cache, and let's see if something will be broken with deprecation only

Looking for better wording as Comment::permalink() is useless 📌 Rename Comment::permalink() to not be ambiguous with ::uri() Needs work

That's reason why issue used to have such title

updated IS

Comment::permalink() isn't useless, it's necessary to link to a comment in the context of the thread (with the correct page and comment fragment). I think we can just tell people to use that until it's renamed. However why not recommend $comment->uri() here?

samit.310@gmail.com → made their first commit to this issue’s fork.

Hello,

The comment_uri function is only been used in uri_callbackcomment entity's annotation.

As per https://www.drupal.org/project/drupal/issues/2667040 📌 Deprecate uri_callback in routes for entities Needs work ticket the uri_callback is also depricated.

In template_preprocess_comment hook $comment->permalink(); is already been used to generate Comment link.

Thanks
Samit K.

Title says to deprecate the function so that still needs to be done

Hi @smustgrave,

As per the changes record [#3384294] it is deprecated in 10.2.0 and will removed with 11.x, so i removed it for 11.x branch.

Thanks
Samit K.

Yes but it got missed so now needs to be properly deprecated

Hi @smustgrave,

Updated the code based on your suggestion. Also updated the changes record [#3384294] → .

Thanks
Samit K.

Thanks only thing missing is a quick deprecation test

Hi @smustgrave,,

Test also added, Please review.

Thanks
Samit K.