StylePluginBase doesn't apply render contexts set in child classes for the rendering of rows in Views

Created on 24 November 2019, over 5 years ago
Updated 26 February 2025, 9 days ago

Problem/Motivation

How to reproduce:
- Install Standard install profile
- Create a piece of content
- Go to admin/content
- apply any filter (for example, status);
- Notice the destination parameter of the edit link does not include the filter
- Clear Drupal caches
- reload page
- Notice the destination parameter of the edit link now includes the filter
- Click the Reset button
- Notice the destination parameter of the edit link still includes the filter

Why we have issue:
Views is doing the rendering row from cache (if the cache is exist), without any checking of cache context.

Added the fix for correct rendering of rows, for different styles, which are supporting the caching system.
Actually, issue tested ONLY for the "Table" style and only for links with destination.

Proposed resolution

Need to use the cache contexts of current Views Style.

Remaining tasks

add tests, commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component

views.module

Created by

πŸ‡ΊπŸ‡¦Ukraine uzlov

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024