Contrib.social

Export approved translations only is ignored

Open on Drupal.org →
Created on 8 November 2022, almost 3 years ago
Updated 21 July 2025, about 1 month ago

Problem/Motivation

Crowdin Enterprise handles the export of translation which are not approved differently and uses different options in the API.

The exportApprovedOnlyproperty doesn't exists, but there's a exportWithMinApprovalsCount. Instead of a boolean, this is a int indicating how many times a file needs to be approved.

Another parameter which should be taken into account is: exportStringsThatPassedWorkflow. How that exactly maps to the approval progress I don't know.

Steps to reproduce

  1. Set "Export translations with a specific number of approvals" in the Crowdin Project Settings to something greater than 0
  2. Sumit Translation Job
  3. Translate 100% without Approving
  4. Fetch Translations

Expected result: No translations are fetched.
Observed result: All translations which reached 100% are fetched

Proposed resolution

Take into account the differences between the general API and the Enterprise API by supporting both exportWithMinApprovalsCount, exportApprovedOnly and possibly exportStringsThatPassedWorkflow.

Remaining tasks

Review/improve patch/MR

User interface changes

-

API changes

-

Data model changes

-

🐛 Bug report
Status

Needs work

Version

1.3

Component

Code

Created by

🇨🇭Switzerland phma Basel, CH

Live updates comments and jobs are added and updated live.
  • Needs reroll

    The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024