- Merge request !17Issue #3319676 by phma: Export approved translations only is ignored. → (Open) created by dhruv.mittal
I've rerolled and created MR for easy review
Please review
Thanks
Crowdin Enterprise handles the export of translation which are not approved differently and uses different options in the API.
The exportApprovedOnly
property doesn't exists, but there's a exportWithMinApprovalsCount
. Instead of a boolean
, this is a int
indicating how many times a file needs to be approved.
Another parameter which should be taken into account is: exportStringsThatPassedWorkflow
. How that exactly maps to the approval progress I don't know.
Expected result: No translations are fetched.
Observed result: All translations which reached 100% are fetched
Take into account the differences between the general API and the Enterprise API by supporting both exportWithMinApprovalsCount
, exportApprovedOnly
and possibly exportStringsThatPassedWorkflow
.
Review/improve patch/MR
-
-
-
Needs work
1.3
Code
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I've rerolled and created MR for easy review
Please review
Thanks