Fix the issues reported by phpcs

I will review this.

Thanks @samit.310@gmail.com, patch #2 applied cleanly, all errors and warnings are fixed.
And i also created MR for same.
Please review.

-`composer require oomphinc/composer-installers-extender npm-asset/quicklink:^2.0`
+`composer require oomphinc/composer-installers-extender
+ npm-asset/quicklink:^2.0`

Lines showing commands should not be split on two or more lines or be formatted to make clear the command is only one.

 /**
- * Class QuicklinkConfig.
+ * The Class QuicklinkConfig.
  */
 class QuicklinkConfigForm extends ConfigFormBase {

That description is still repeating the class name instead of describing what the class does.
Also, the report does not show any warning/error for that line, which means that either the report is not complete, or the patch is changing files that should not change. (I take it is the first, since Class QuicklinkConfig. is not describing what the class does.)

+  /**
+   * The quicklink_config_form_validate function.
+   * @codingStandardsIgnoreStart
+   */
   public function quicklink_config_form_validate($form, &$form_state) {

There is no need to use @codingStandardsIgnoreStart.

 dependencies:
-  - quicklink
+  - drupal:quicklink

The Quicklink module (this module) is not a Drupal core module.

bindu r → made their first commit to this issue’s fork.

Anita Verma → made their first commit to this issue’s fork.

Hello

Updated the suggested changes as per #6 .
Kindly review the changes.
Thankyou.

Hello,
After checking, I discovered one more error.

apaderno → changed the visibility of the branch 3329641-drupal-coding-standards to hidden.

It seems part of the changes done in this issue has been already committed. The only PHP_CodeSniffer error reported by GitLab CI is the following one.

FILE: ...9641/web/modules/custom/quicklink-3329641/src/Form/QuicklinkConfigForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 65 | ERROR | Public method name
    |       | "QuicklinkConfigForm::quicklink_config_form_validate" is not in
    |       | lowerCamel format
    |       | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps)
--------------------------------------------------------------------------------
Time: 237ms; Memory: 6MB

Trully, that method can be removed: It is not used and it duplicates

  /**
   * The validateForm method for the QuicklinkConfigForm.
   */
  public function quicklink_config_form_validate($form, &$form_state) {
    $parameterFieldsToValidate = [
      'total_request_limit',
      'concurrency_throttle_limit',
      'viewport_delay',
      'idle_wait_timeout',
    ];

    foreach ($parameterFieldsToValidate as $value) {
      $formValue = $form_state['values'][$value];
      if ($formValue !== '' && (!is_numeric($formValue) || intval($formValue) != $formValue || $formValue < 0)) {
        form_set_error($value, $this->t('%name must be a positive integer or zero.', [
          '%name' => $form['throttle_options'][$value]['#title'],
        ]));
      }
    }
  }

  /**
   * {@inheritdoc}
   */
  public function validateForm(array &$form, FormStateInterface $form_state) {
    $parameterFieldsToValidate = [
      'total_request_limit',
      'concurrency_throttle_limit',
      'viewport_delay',
      'idle_wait_timeout',
    ];

    foreach ($parameterFieldsToValidate as $value) {
      $formValue = $form_state->getValues()[$value];
      if ($formValue !== '' && (!is_numeric($formValue) || intval($formValue) != $formValue || $formValue < 0 || $formValue < '')) {
        $form_state->setErrorByName($value, $this->t('%name must be a positive integer or zero.', [
          '%name' => $form['throttle_options'][$value]['#title'],
        ]));
      }
    }
    parent::validateForm($form, $form_state);
  }

Hi

I applied the updated MR !9 and I can confirm that it fixes PHPCS issues

➜  quicklink git:(2.0.x) curl https://git.drupalcode.org/project/quicklink/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10100    0 10100    0     0  15314      0 --:--:-- --:--:-- --:--:-- 15467
patching file .gitlab-ci.yml
patching file README.md
patching file quicklink.install
patching file quicklink.module
patching file 'src/Form/QuicklinkConfigForm.php'
patching file 'tests/quicklink_test/quicklink_test.info.yml'
➜  quicklink git:(2.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml quicklink 
➜  contrib git:(master) ✗ 

retaining the status to needs review for other's feedback