- Issue created by @urvashi_vora
- ๐ต๐ญPhilippines kenyoOwen
Hi urvashi_vora
I applied the patch coding-standard-fixes.patch โ to the โUI Styles Paragraphsโ module against Version 1.x-dev and confirmed that the errors and warnings are resolved. Please see the screenshots attached.
For your review.
Thank you. - Status changed to RTBC
almost 2 years ago 1:38pm 20 April 2023 - Status changed to Needs work
over 1 year ago 11:41am 24 July 2023 - ๐ฉ๐ชGermany sharique
Thanks for the patch, the current patch is not applying. Some of the PHPCS issue might be fixed with other issue, please provide updated patch, if some issues are still present.
- Status changed to Needs review
over 1 year ago 5:00am 25 July 2023 - ๐ฎ๐ณIndia mrinalini9 New Delhi
Added an updated patch for the remaining phpcs issues, please review it.
Thanks!
- ๐ฎ๐ณIndia anjali mehta
Hello @mrinalini9
Tested 3353697-5.patch on Drupal 9.5 and php version 8.1. Patch applied cleanly. But getting a warning and error on running the phpcs. Adding screenshot for Your references. Please have a look.
Thank You . Hi, patch 3353697-5.patch #5 applied cleanly.
Tested on drupal 10.1 and php version 8.1
Applied patch and ran these commands:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ui_styles_paragraphs/
uploaded screenshot for reference.- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia dev16.addweb
I have tested #5 and raised MR for the same. Please review and merge this MR.
- ๐ฎ๐ณIndia vinmayiswamy
Hi,
I applied MR!4 to the ui_styles_paragraphs module against version ui_styles_paragraphs 1.1.x-dev in Drupal 10.2.x and confirmed that the errors and warnings reported by phpcs are resolved. Please see the screenshots attached.
Thanks!
- Status changed to RTBC
9 months ago 10:48am 8 July 2024