sharique → created an issue.
just_like_good_vibes → credited sharique → .
I performed a quick test this on UI pattern 2.0, and this is issue in not present in the v2.0.
g4mbini → credited sharique → .
g4mbini → credited sharique → .
g4mbini → credited sharique → .
I tested with latest version of both modules, it is working fine now.
sharique → created an issue.
sharique → created an issue.
I've updated patch to apply on 5.2.2.
I had to remove the call to libraries alter, as it still loading from CDN even when I've in local, so that needs to be checked again.
Thanks IT-CRU for patch, plyr.svg image is still loading from CDN, so I updated patch to load from local libraries.
Same change is done for 1.1.x branch and created a new release.
g4mbini → credited sharique → .
I've re-rolled the patch against latest release 1.15.
G4MBINI → credited Sharique → .
Sharique → created an issue.
I've create a simple form, with one text input on submit value is displayed as label.
I ran into issue that, after submit it replacing complete page in the container.
Once I get it working, I'll work on creating a complex multi step form.
G4MBINI → credited Sharique → .
It is due to font Awesome is not providing data.
https://github.com/FortAwesome/Font-Awesome/issues/18662
Sorry, if I'm distracting from main topic, I want to highlight a scenario, which I think might be useful in making decision here, feel free to move it to separate ticket. So scenario is like this
- There is a component in base theme called card.
- For project A, created a new sub theme A
- There is a requirement to a new variant of card in project A
- Simple solution is to define a new variant in base theme, and implement it in sub-theme. Downside of this approach is in some cases it might break existing sites based base theme and base them may end up with many variant which are specific to projects.
- Another approach is define a new variant in sub theme only. [It requires this ticket and 📌 Make SDC extensible Active ]. This will keep base theme clean.
Sharique → created an issue.
Thanks for quick reply, I'll check these.
Sharique → created an issue.
Big +1 from me also.
Here is a patch this, I removed ui_patterns_library from composer, as this is now moved to ui_patterns module.
Sharique → created an issue.
I suggestion for I've is to switch to storybook instead of NPM plugin.
G4MBINI → credited Sharique → .
+1 for RTBC.
I find out why it is not showing up.
When webform are added in antibot configuration, which mean it is enabled for all webforms, in this case antibot setting for each webform is not displayed.
Which make sense, a message on the webform will be good to avoid confusion.
G4MBINI → credited Sharique → .
@cwales95, yes, you can. Please test with latest code in branch as well.
I'll appreciate if you can post a patch as well.
Unfortunately, I don't have enough time to look into issues.
Thanks, can we have a new release?
+1 for RTBC, it is working as expected.
adriancid → credited Sharique → .
This module connect paragraphs module and UI styles module, properties definition of style belongs to the UI style module, hence moving ticket.
There is already a related ticket
✨
UX: Add other widgets than select
Active
Thanks BenStallings, good find.
Sharique → created an issue.
I tested this patch with better exposed filters, and is working.
Sharique → created an issue.
G4MBINI → credited Sharique → .
IMHO, since SDC can be implemented theme or module, it doesn't make sense to create a new project type. For now a tag or flag saying this module/theme implement components in SDC format would be good.
Please check with 🐛 Patterns library doesn't detect other activated theme patterns (only from the basetheme) RTBC .
I updated documentation, this going to be changed again in 2.0.
@grimreaper, I'm unable to reproduce issue in local. Steps I followed are follows,
1. Installed UI Suite Bootstrap 5 theme on vanilla Drupal 10.2 installation.
2. Create a new paragraph Text
3. Enabled some UI Styles for this paragraph type and saved.
4. Again edited paragraph type, only previously enabled check boxes are checked.
5. I tested with claro and gin admin themes.
There is already a service defined "readonlymode.manager", it has a method isReadonly, which you can call to check if read only mode is enabled or not.
Thanks Samit for patch, I did minor changes.
For creating multiple previews of pattern, I think best approach is to create examples page using https://www.drupal.org/project/ui_examples → or create story using storybooks.
I'm not using ui_patterns_field_variants module.
For now I've enabled UI patterns library module on envs.
Thanks for suggestion, it works, now I can remove amymodule_entity_base_field_info_alter.
This is fixed, and created release. Please test.
I've created a new release. Will appear in few hrs.
Can you please provide more details about this?
For me all checkboxes are unchecked.
Do you have categories defined for UI Styles?
I'm able to solve above issue by adding "use" attribute
use: "@base/main/patterns/cta_with_icon/pattern-cta-with-icon.html.twig"
Now the issue, all other fields and setting not visible in preview and also in pattern mapping in paragraph display modes. Check attached screenshot of preview
Sharique → created an issue.
Sharique → created an issue.
Sharique → created an issue.
IMHO it is better to make this as a separate checkbox.
Sharique → created an issue.
I tested latest release of theme, and it is working fine.
G4MBINI → credited Sharique → .
Can we have a new release?
Thanks Scott for quick reply, yes there modules which provides the field. What I'm looking the the color field form element to integrate in layout options, which I didn't find so far.
Thanks for quick fix, it is working.
I've one question, I see that form field takes color values as input, but in my case I don't want to provide any values. Content editor can pick any value. How I can achieve this?
Sharique → created an issue.
Sharique → made their first commit to this issue’s fork.
Sharique → created an issue.
I see overlap in case of layout paragraphs, because we are using extensively. And this is already in a way. Not sure about other scenarios.
Anyway we can revisit this later.
New widgets will be really helpful.
With new widget options, there is an overlay with layout options in certain scenarios, for example in case of layout paragraphs, we can add same setting either using UI Styles or layout options.
G4MBINI → credited Sharique → .
There is are still a tricky things to handle beside, in HTML5 color input there is no way to unset the value, and default value is black.
One more thing I want to do is to be able to add opacity for the color option,
G4MBINI → credited Sharique → .
Sharique → created an issue.
Thanks @Grimreaper for tip, in my I need to add value using single quote.
Uploading correct patch file.
Sharique → created an issue.
Sharique → created an issue.
Thanks asherry for the patch, now I'm getting this error,
Drupal\sdc\Exception\InvalidComponentException: [items] NULL value found, but an array or an object is required in Drupal\sdc\Component\ComponentValidator->validateProps() (line 201 of /app/web/core/modules/sdc/src/Component/ComponentValidator.php).
I tried experimenting with pager component, but not able to solve the issue yet.
BTW I was testing with 5.1.1-alpha2
Thanks for checking, I'm still getting WSOD, not what exactly the reason behind this, there is no other SDC components mentioned in code base.
Updated patch to fix import.
Same issue present in 1.4.x, here is the patch. This fixed the issue for export, but import in case of zip file only.
When importing using paste, the behavior settings are not imported correctly.
Sharique → created an issue.
Yes, all 3 modules and stable9 theme is enabled.
Sharique → created an issue.
Thanks @grimreaper for you efforts, this PR is not applying for me on both 1.5 release as well as dev release.
Sharique → created an issue.
Thanks for the patch, the current patch is not applying. Some of the PHPCS issue might be fixed with other issue, please provide updated patch, if some issues are still present.
Thanks @vbouchet for the patch.