- Issue created by @BenStallings
- Status changed to Needs review
over 1 year ago 10:51pm 8 December 2023 - πΊπΈUnited States BenStallings
While I was at it, I also provided an empty string to satisfy the trim() function in case $pet->getMailbodyPlain() returns null.
-
Sharique β
committed 8c747d10 on 8.x-4.x
Issue #3407135 by BenStallings: Language is not a required parameter
-
Sharique β
committed 8c747d10 on 8.x-4.x
- Status changed to Fixed
about 1 year ago 3:11pm 28 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- π¬π§United Kingdom cwales95
Hi, this issue doesn't seem to be fixed.
The issue persists because the code in
pet_substitutions
expects$params['language']
to be set but$params['language']
is set directly afterpet_substitutions
is called.Can we reopen this issue?
- π©πͺGermany sharique
@cwales95, yes, you can. Please test with latest code in branch as well.
I'll appreciate if you can post a patch as well.
Unfortunately, I don't have enough time to look into issues. - πΊπΈUnited States BenStallings
@Sharique I've updated the branch, but I am unable to reopen the issue. It says "Only maintainers can reopen."
- πΊπΈUnited States BenStallings
@sharique yes, and I had already done so at https://git.drupalcode.org/project/pet/-/merge_requests/5/diffs?diff_id=... , but for some reason https://git.drupalcode.org/project/pet/-/merge_requests/5/diffs shows an incorrect "latest version" until you select "latest version" again.