Allow to not load plyr.js from a CDN

Created on 20 December 2023, 12 months ago
Updated 6 September 2024, 3 months ago

Problem/Motivation

Currently plyr.js is loaded from https://cdn.plyr.io/ - this has GDPR implications and should be made optional.

Steps to reproduce

Activate the module, embed a youtube video and check teh network tab. https://cdn.plyr.io/3.7.3/plyr.js is loaded no matter what.

Proposed resolution

Make this optional via some settings and use plyr as drupal library instead.

Feature request
Status

Postponed: needs info

Component

Code

Created by

🇩🇪Germany Schoenef Unna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Schoenef
  • Status changed to Postponed: needs info 6 months ago
  • 🇩🇪Germany IT-Cru Munich

    With attached patch you could use Plyr libraries installed via composer over npm-asset packagist.

    In general I would like to avoid loading Plyr libraries over CDN and switch to something like npm-asset via https://asset-packagist.org until Drupal community decide which would be the way to go to require such JS library dependencies.

    Would be nice to get some feedback here, how other Plyr users / developers think about this :)

  • 🇮🇳India Sharique

    Thanks IT-CRU for patch, plyr.svg image is still loading from CDN, so I updated patch to load from local libraries.

  • 🇩🇪Germany IT-Cru Munich

    @sharique: I already saw this, but didn't checked that it is possible to override it for Plyr library. Thx!

Production build 0.71.5 2024