Role back of patch from #26 as MR to apply against 11.x and 10.3.x again.
One kernel and some functional unit tests are failing in Gitlab CI jobs now, but I have no clue why this wasn't previously the case. So I think this needs some more investigations.
Created issue related MR from patch from @seutje and hide his uploaded patch.
With attached patch you could use Plyr libraries installed via composer over npm-asset packagist.
In general I would like to avoid loading Plyr libraries over CDN and switch to something like npm-asset via https://asset-packagist.org until Drupal community decide which would be the way to go to require such JS library dependencies.
Would be nice to get some feedback here, how other Plyr users / developers think about this :)
Fix for remaining cspell warnings looks fine for me.
Do we also need to adjust / inform someone who already created related PO translation files for date_filter contrib module?
Used provided patch from @seutje to create MR for better review and hide uploaded patch.
Marked as duplicate: Will be resolved by ✨ Optimize drush command Needs review .
We also should try to add new Drush command options to PHPUnit testing or open a related issue for this.
Added Drupal Gitlab CI template and already resolved all easy to fix reported errors.
Tested in my local environment with some manual created German translations.
Tested patch of MR and for me it is working when using a https://youtu.be/ short URL.
@geek-merlin @heddn @volkerk Should 🐛 Changes are lost when collapsing a paragraphs subform including an inline_entity_form Needs work maybe also added to 3.x stable release plan because it seems not be fixed in 8.x-1.x yet.
IT-Cru → changed the visibility of the branch 3340456-update-readme.md-file to hidden.
IT-Cru → changed the visibility of the branch 3265924-add-hookhelp to hidden.
Works fine for a long time at our PROD environments now, so I would merge this to prepare a new release.
Existing MR needs rebase.
+1 for a new beta release :)
@kerrymick: Should current state of 5.0.x be tagged as hotfix 5.0.1 to avoid issues for people who tries to upgrade from 8.x-2.x to 5.0.x because of this issue detected by PHPStan CI job (mentioned in #7?
I think this would be a good idea to avoid popup of follow up issues with broken upgrades.
I've rebased open MR to get Gitlab CI jobs running for this issue now.
All pipelines are green with drupal/ctools (4.0.4) downloaded at composer CI job.
@jcnventura: Do you remember if any changes in your projects are needed when Cloudflare module is used with ctools 4.0.x?
@RoSk0: If nothing more is needed I would say this could be a candidate for merge and a quick release :)
In MR to 5.0.x I can't find this issue. So it seems to be only related to 8.x-2.x branch.
If this is already included in latest release, I think it would be good to create a new issue as critical bug, because of this typo TWIG model template is broken.
@thejimbirch Does it also make sense to add Gitlab CI templates to 8.x-2.x branch because of current usages?
@kerrymick @thejimbirch: I've raised this to major because PHPStan found a possible issue in update path. See my changes in bp_card.install file. Maybe these changes should be cherry picked for a 5.0.1 hotfix release.
IT-Cru → changed the visibility of the branch 3437111-add-drupal-gilab to active.
IT-Cru → changed the visibility of the branch 3437111-add-drupal-gilab to hidden.
@twills: Diff of MR should apply again with 8.x-2.x-dev.
@thejimbirch @kerrymick: Is this change already addressed in development of 5.0.x branch?
Added current state of MR as patch against 2.0-beta8 release before rebase.
@Dave Reid: There is already a hook_entity_delete() implemented since 5 years in the module. So normally all access tokens should be deleted, when a host entity gets deleted.
/**
* Implements hook_entity_delete().
*/
function access_unpublished_entity_delete(EntityInterface $entity) {
/** @var \Drupal\access_unpublished\AccessTokenManager $tokenManager */
$tokenManager = \Drupal::service('access_unpublished.access_token_manager');
foreach ($tokenManager->getAccessTokensByEntity($entity) as $token) {
$token->delete();
}
}
I hope I missed nobody in giving credits to help working on this issue. Otherwise please leave a message here, before ticket is finally closed :)
Marked as fixed because Image Style Warmer 8.x-1.2 release is already tagged.
@dcam @larowlan Should issues reported by PHPCS CI job also addressed in this issue? If yes I could work down some or maybe all of them.
Switch to needs review to get feedback and get a decision from maintainers about remaining tasks.
For Youtube playlists there was already an issue in the past 🐛 YouTube PlayLists can't be added to Remote Video due to regex issue. Fixed which added possibility to add Youtube playlists via Drupal core's remote_video media entity.
@laura.gates: Is your oEmbed providers.json up2date?
@jcnventura My intention wasn't to highjack this issue. Only wanted to provide information why tests for 10.2 are currently failing and in what direction at the end we should move.
I totally agree that MR which also allow ctools 4.x should be merged, but on the other hand maintainers could be stucked, when CI testing fails.
Problem with D10.2 seems to be related to psr/http-message: ~1.0 requirement of cloudflare/sdk package which conflicts with psr/http-message requirement of Drupal core 10.2.
I think biggest problem with cloudflare/sdk is that Cloudflare announced it as deprecated and will not provide development here anymore.
https://github.com/cloudflare/cloudflare-php/issues/235
So we could try to fork cloudflare/sdk and add possibility to also allow usage of psr/http-message:2.x but I think it will only solve our issue temporary because of developer resources.
https://github.com/cloudflare/cloudflare-php/issues/249
In general it would be better to use provided Cloudflare API v4 in drupal/cloudflare module instead of cloudflare/sdk.
Fixed since 1.0.0-alpha2 release.
I've opened a MR based on patch from #90 and adjust this to recent supported Drush version 11/12 to make testing and reviewing easier for all of us.
Patch from #91 has strange format so it was not possible to apply for me.
I think we should also discuss with maintainers of https://www.drupal.org/project/vde_drush → module to merge Drush commands back into views_data_export code base.
All Drupal Gitlab CI jobs are green now, but previous existing phpunit tests are now only working with D10.2 or higher.
There are also some D9 based phpunit tests which were previously skipped, but not removed yet.
@apaderno If you have time, maybe you could double check if I resolved all our review comments in a proper way.
Issues reported by PHPSTAN Gitlab CI job I will fix in another MR :)
Issue is also fixed for me when using entity_clone on projects which are based on Thunder distribution.
@Anybody: I've created drupal/vidstack_player module project, added you as co-maintainer and created 🌱 [meta] Discuss how we want to start Active for further discussions.
I need to check, if I could join Drupal Contribution Weekend 2024 this year.
@Anybody: Yes, I think we should start a new Drupal vidstack project. I haven't done this previously because vidstack player was not ready for Youtube and Vimeo.
Current question: Should we create this as vidstack or vidstack_player project, because I think Vidstack team also plans a lot of other stuff and not only their player.
- drupal/vidstack: More for integration with vidstack systems in general like CMS, analytics, upload and so on.
- drupal/vidstack_player: As a sub-module of drupal/vidstack or standalone for Vidstack player component?
Tested together with PR for Thunder 7.1.x and fixed issue for us with missing edit all paragraphs button after update from Thunder 6.5.x.