- Issue created by @DamienMcKenna
- Status changed to Needs review
11 months ago 12:15pm 10 January 2024 - last update
11 months ago 2 fail The last submitted patch, 2: views_rss-n3413726-2.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
11 months ago 10:59am 11 January 2024 - last update
11 months ago 1 fail - πΊπΈUnited States DamienMcKenna NH, USA
Hopefully this will fix the test failure.
The last submitted patch, 5: views_rss-n3413726-5.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs review
11 months ago 11:28am 11 January 2024 - Open on Drupal.org βCore: 10.2.x + Environment: PHP 8.2 & MySQL 8last update
11 months ago Waiting for branch to pass - πΊπΈUnited States DamienMcKenna NH, USA
This adds a new date format plugin, adds an update script to install it and changes the tests to use it.
- πΊπΈUnited States DamienMcKenna NH, USA
Working on π Fix tests against Drupal 10.2 Needs review .
- πΊπΈUnited States DamienMcKenna NH, USA
This needs to be in the next release.
- First commit to issue fork.
- Merge request !10Resolve #3413726 "Date values should be in RFC-822 format, not RFC-2822" β (Closed) created by ivnish
- Status changed to RTBC
5 months ago 7:12am 19 July 2024 - ivnish Kazakhstan
I convert Damien's patch to MR and test it. Works as expected
-
DamienMcKenna β
committed 48d56fbe on 8.x-2.x
Issue #3413726 by DamienMcKenna, ivnish: Date values should be in RFC-...
-
DamienMcKenna β
committed 48d56fbe on 8.x-2.x
- Status changed to Fixed
5 months ago 10:43am 19 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- π©πͺGermany IT-Cru Munich
@damienmckenna: I would recommend to re-open this issue again, because with current used custom PHP date format in provided config it could produce issue for other languages.
When using your date format for a German only Drupal site you get following date in RSS feeds: Mi., 20 Okt. 21 12:09:11 +0200 which could produce issues in feed consumers because of German day / month names I would say.
Maybe it makes sense to use PHP's predefined constant DATE_RSS here?
- πΊπΈUnited States Maeglin
Also confusing matters is the fact that, while the RSS spec specifies RFC822 (2-digit year) for the date format, the example given in the spec is based on RFC 2822 (4-digit year). It might not be that critical of a problem now, but it will be in around 33 years.