Fix tests, module for Drupal 10.2 & PHP 8.2

Let's see if this solves it, or if there are more problems.

The last submitted patch, 2: views_rss-n3414012-2.patch, failed testing. View results →

Additional fix.

DamienMcKenna → credited sidharth_soman → .

Adding sidharth_soman who worked on a subset of this in #3412474.

The last submitted patch, 4: views_rss-n3414012-4.patch, failed testing. View results →

DamienMcKenna → credited ivnish → .

And ivnish too.

Additional fixes.

The last submitted patch, 11: views_rss-n3414012-10.patch, failed testing. View results →

For some reason the content type header of "application/rss+xml" is not being set. I'm not sure why this changed in 10.2 whereas it worked in 10.1.

Core added the following in the render function of their Rss feed style plugin:

      '#attached' => [
        'http_header' => [
          ['Content-Type', 'application/rss+xml; charset=utf-8'],
        ],
      ],

This was the issue -> https://www.drupal.org/project/drupal/issues/3272985 🐛 RSS Feed header reverts to text/html when cached Fixed

Applying the same change to 8.x-2.x fixes the content type header issue. I can provide as a patch, but should it be in this issue or a new one @DamienMcKenna?

This one, thank you.

Slightly expanding the scope, because so many things are interconnected.

Let's see how this works.

The last submitted patch, 17: views_rss-n3414012-17.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Any updates, Damien?

Rerolled.

The last submitted patch, 21: views_rss-n3414012-21.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

I'm not in a position to keep working on this at the moment, might someone else be able to continue the work?

I can help with tests. Can you make me a co-maintainer?

Thank you for the offer - if you're able to resolve this I'll consider it.

Can you commit .gitlab-ci.yml ? We can use MR with CI pipelines

Done.

@Damien please review. Pipeline is here https://git.drupalcode.org/issue/views_rss-3414012/-/pipelines/194294

I don't fix cspell, phpcs and phpstan issues. I think it's a task for another issue

Committed. Thank you!

And ivnish, welcome to the team!

Automatically closed - issue fixed for 2 weeks with no activity.