[meta] Discuss how we want to start

Thanks @IT-Cru could you perhaps give a short summary, what you think would be best and why?
We planned to use the plyr module, but didn't have the time yet. We came back some days ago to take a look at the status and plan integration. So I think you have a clearer view on the status and architecture of the module.

@thomas.frobieter and me should also install the module and check how it works and what it provides to gain insight.

@IT-Cru would it make sense to copy the module implementation from https://www.drupal.org/project/plyr → as starting point?

We'd start with the vidstack_player implementation now and I think plyr looks good? Do you have time to help currently?

@anybody would be good to address directly following issues in vidstack_player code base:

• 🐛 Plyr expects loop option to be object instead of boolean Needs work
• ✨ Add option to start video muted Needs review
• 🐛 Not working when a file fields allowed number of values is set to unlimited Needs review

Optional:

• ✨ Allow to not load plyr.js from a CDN Active
  (maybe similar like webform contrib module is doing it with required libraries)

What do you and your team think about it.

@it-cru thanks for your feedback! So would you suggest using the plyr implementation as basis for the vidstack implementation?
Currently it looks like @lrwebks started from scratch.

Is there a plan from your side to proceed working on vidstack or plyr in the near future? (We'll definitely proceed here now, so would be great to push this forward together)

@anybody I didn't entirely start from scratch, most of the code is initially taken from the Plyr module and then modified to fit Vidstack, but also some entirely custom things. I figured that this would be the best approach, since we were discussing to take the Plyr code as a starting point. On the other hand, there were lots of things that aren't needed for Vidstack, so I went with cherry-picking.

Starting from scratch is also fine for me to have a clean and modern code base. For some first testing I could also use 1 of my sites with Vimeo and YouTube videos when first throw has base functions.

Branches we should double check. No clue how current best workflow on d.o is, but I think we should start in 1.0.x branch instead of 1.x to have later possibilities to provide with version 1 different Drupal core compatible releases. What do you think about it?

Upgrade path we maybe could provide later as howto or if possible via code, but currently I would not focus on it.

Thank you all for the feedback! I'll leave this for @lrwebks and @thomas.frobieter for now to decide, as I'm on holiday currently.

Regarding

I think we should start in 1.0.x branch instead of 1.x to have later possibilities to provide with version 1 different Drupal core compatible releases. What do you think about it?

I'd always vote for 1.x as the minor branches always made things very complex in my experience. Let's focus on Drupal 11 for now, maybe 10.3. Let's use -alpha1 as long as possible while under heavy development to keep flexiblity.

Yeah an upgrade paths from plyr might be a nice feature in the future. :)

@lrwebks: Please look at the plyr code based and the listed issues to decide what to move over and what not, together with @thomas.frobieter.