- Issue created by @hdotnet
- Assigned to brunapimenta
- π§π·Brazil brunapimenta
I'll start taking a look on suggestion of the Comment on Github, wherein Cloudflare indicates the usage of API directly.
- last update
over 1 year ago run-tests.sh fatal error - @brunapimenta opened merge request.
- Status changed to Needs review
over 1 year ago 10:48pm 14 June 2023 - π§π·Brazil brunapimenta
I've provided a fork removing Cloudflare SDK dependency, for that I've chosen to bring to Cloudflare Drupal module the SDK needed code - in which is the one related to Zone (listing and caching purge).
It was validated using a Drupal vanilla installation, everything worked smoothly after applying #3346396 - admin/config/services/cloudflare Slow to Load π admin/config/services/cloudflare Slow to Load RTBC solution.
Note
Since SDK code followed an Object-Oriented Programming, I've kept as is. Even though at the end it looked a complex solution to a simple need, it can provide flexibility porting more code from that library on the future. - last update
over 1 year ago 57 pass - πΊπΈUnited States neclimdul Houston, TX
oof. I'm going to end up being "that guy that just maintains automated builds of OpenAPI libraries because companies can't be bothered to build a CI."
I'll get something built that can be used as a replacement.
- last update
9 months ago 57 pass - last update
9 months ago 57 pass - π³πΏNew Zealand RoSk0 Wellington
I don't think that copying code from the SDK is a good idea - SDK is old, covers a lot of API endpoints and have a lot of complexity for various use case this module should not need to care about.
Before diving into the solution we need to map out what API endpoints we are actually need to interact with and possibly create child issue to split the work where possible.
I'm not sure, but it feels like this type of change should warrant major version number increase.
And in any case, we need to get π Add Drupal Gitlab templates Needs work merged first.
- π¬π§United Kingdom alexpott πͺπΊπ
@RoSk0++ to only bringing in what you need from the SDK. And yes new major sounds like a good idea.