- Issue was unassigned.
- 🇮🇳India saranyamariappan
MR has been created after fixing PHPCS errors. Please review.
- Status changed to Needs work
10 months ago 7:04am 28 January 2024 Hi, I reviewed the MR and found many phpcs issues while running the command
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_cdt/
So, changing the status to Needs workCreate a patch to fix the phpcs errors.
These errors are remaining:$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tmgmt_cdt/ FILE: C:\Users\Nisha\tmgmt_cdt\src\TmgmtCdtApi.php ----------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------- 1415 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces, found 2 ----------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------- FILE: C:\Users\Nisha\tmgmt_cdt\src\TmgmtCdtFormatHelper.php ------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------- 134 | WARNING | Code after the THROW statement on line 133 cannot be executed 140 | WARNING | Code after the THROW statement on line 139 cannot be executed -------------------------------------------------------------------------------
Thankyou.
- First commit to issue fork.