Drupal Coding Standard As Per 'phpcs --standard=Drupal'.

Adding patch, please review.

@chaitanyadessai

Thanks for the Work.

Verified and tested patch #2 on Business theme 9.1. x-dev Applied cleanly, but it gives errors.

git apply -v 3353194-2-Drupal_Coding_Standard_As_Per_phpcs.patch
3353194-2-Drupal_Coding_Standard_As_Per_phpcs.patch:1646: trailing whitespace.
      if (!data) $this.data('bs.button', (data = new Button(this, options))) 
Checking patch css/blue.css...
Checking patch css/brown.css...
Checking patch css/flexslider.css...
Checking patch css/green.css...
Checking patch css/orange.css...
Checking patch css/red.css...
Checking patch css/style.css...
Checking patch css/yellow.css...
Checking patch includes/bootstrap/css/bootstrap.css...
Checking patch includes/bootstrap/js/bootstrap.js...
Checking patch js/custom.js...
Applied patch css/blue.css cleanly.
Applied patch css/brown.css cleanly.
Applied patch css/flexslider.css cleanly.
Applied patch css/green.css cleanly.
Applied patch css/orange.css cleanly.
Applied patch css/red.css cleanly.
Applied patch css/style.css cleanly.
Applied patch css/yellow.css cleanly.
Applied patch includes/bootstrap/css/bootstrap.css cleanly.
Applied patch includes/bootstrap/js/bootstrap.js cleanly.
Applied patch js/custom.js cleanly.
warning: 1 line adds whitespace errors.

Please check.

Create a patch Please Review it. I have attached a interdiff for the same.

Hi Akshay kashyap

I reviewed patch #5, and there are still remaining errors shown below:

FILE: /Users/studenttrainees/New/drupalorgsite/docroot/themes/contrib/business/includes/bootstrap/css/bootstrap.css
-------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------
3294 | ERROR | Style definitions must end with a semicolon
6079 | ERROR | Style definitions must end with a semicolon
6090 | ERROR | Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------

Time: 1.71 secs; Memory: 50.01MB

Please check.
Thank You.

Added patch again to fix the remaining issue please check.

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command and arguments have been used, and which report that command shown.

Tested the #7 patch, confirmed it will fix all issues.

The Reviewed & tested by the community status can be set by somebody who didn't provide the last patch.

-      '#title' => t('Slide '.$i),
+      '#title' = t('Slide @number Title', ['@number' => $i]);

Using a placeholder is correct, but there is no need to add Title, which is also misspelled, since it is not at the beginning of the title.

-    if (e) e.preventDefault()
+    if (e) { e.preventDefault()
 
     if (!$parent.length) {
       $parent = $this.hasClass('alert') ? $this : $this.parent()
     }
+    }

That code is not correctly indented.

-    if (e.isDefaultPrevented()) return
+    if (e.isDefaultPrevented()) { return
 
     $parent.removeClass('in')
 
     function removeElement() {
       $parent.trigger('closed.bs.alert').remove()
     }
+    }

The changed code is the following one.

    if (e.isDefaultPrevented()) { return
 
     $parent.removeClass('in')
 
     function removeElement() {
       $parent.trigger('closed.bs.alert').remove()
     }
    }

That is wrong for at least two reasons, considering the existing code is the following one.

   if (e.isDefaultPrevented()) return
 
     $parent.removeClass('in')
 
     function removeElement() {
       $parent.trigger('closed.bs.alert').remove()
     }

-      if (!data) $this.data('bs.alert', (data = new Alert(this)))
-      if (typeof option == 'string') data[option].call($this)
-    })
+      if (!data) { $this.data('bs.alert', (data = new Alert(this)))
+      if (typeof option == 'string') { data[option].call($this)
+    }
+      }
+      })

-    if (!data.resetText) $el.data('resetText', $el[val]())
+    if (!data.resetText) { $el.data('resetText', $el[val]())
 
     $el[val](data[state] || this.options[state])

-      if ($input.prop('type') === 'radio') $parent.find('.active').removeClass('active')
+      if ($input.prop('type') === 'radio') { $parent.find('.active').removeClass('active')
     }
+      }

-      if (!data) $this.data('bs.button', (data = new Button(this, options)))
+      if (!data) $this.data('bs.button', (data = new Button(this, options))) 
 
       if (option == 'toggle') data.toggle()
-      else if (option) data.setState(option)
-    })
+      else if (option) { data.setState(option)
+    }
+      })

-    if (!$btn.hasClass('btn')) $btn = $btn.closest('.btn')
+    if (!$btn.hasClass('btn')) { $btn = $btn.closest('.btn')
     $btn.button('toggle')
     e.preventDefault()
-  })
+  }
+    })

-    if (pos > (this.$items.length - 1) || pos < 0) return
+    if (pos > (this.$items.length - 1) || pos < 0) { return
 
-    if (this.sliding)       return this.$element.one('slid', function () { that.to(pos) })
-    if (activeIndex == pos) return this.pause().cycle()
+    if (this.sliding) {       return this.$element.one('slid', function () { that.to(pos) })
+    if (activeIndex == pos) { return this.pause().cycle()
 
     return this.slide(pos > activeIndex ? 'next' : 'prev', $(this.$items[pos]))
   }
+    }
+    }
+    }

   Carousel.prototype.next = function () {
-    if (this.sliding) return
+    if (this.sliding) { return
     return this.slide('next')
   }
+    }

Those are other wrong changes. The changed code lines are not even equivalent to the existing lines.

please review I have resolved some issues.

Hi, In patch #17, the changes suggested in comment #16 have not been fully addressed; there are still pending changes that need to be addressed.
Thankyou.

I am working on this.

I have fixed the issues. Please review.

Since patches are no longer tested, a merge request needs to be provided.