Drupal 11 compatibility

aaron.ferris → made their first commit to this issue’s fork.

Had an initial stab at this, where the user_roles function has been replaced it seems to be working the same way, needs more testing.

nisha_j → made their first commit to this issue’s fork.

Hi @aaron.ferris

I have switched to your branch and executed upgrade status scan once again. I found some issue in the scan. Attaching below. Please correct me if I am wrong.

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Flag
Scanned on Tue, 05/14/2024 - 08:41.

3 warnings found.

web/modules/contrib/flag/src/Plugin/views/relationship/FlagViewsRelationship.php:
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Fix
later | 148 | Call to deprecated function user_roles(). Deprecated in
drupal:10.2.0 and is removed from drupal:11.0.0. Use
Drupal\user\Entity\Role::loadMultiple() and, if necessary,
an inline implementation instead.
|
+-----------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
web/modules/contrib/flag/tests/src/Functional/AdminUITest.php:
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| status | line | message |
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Check
manually | 188 | Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
|
| Check
manually | 204 | Relying on entity queries to check access by default is
deprecated in drupal:9.2.0 and an error will be thrown from
drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with
TRUE or FALSE to specify whether access should be checked.
|
+----------------+------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+

Hello @PrabuEla

Thanks, yes indeed, I missed FlagViewsRelationship.php. Ill check the other complaints.

Left some comments. This should opt in to NEXT_MAJOR testing so we can verify the tests actually work on D11.

samit.310@gmail.com → made their first commit to this issue’s fork.

samit.310@gmail.com → changed the visibility of the branch 3446713-drupal-11-compatibility to hidden.

Berdir → closed merge request !64

All tests are passing except 📌 FlagFollowerUITest failing since new access policy was committed to core Active and that's failing already on HEAD and fails on all branches.

Not sure how this ended up with so many different branches and merge requests, but *shrug*.

Merged.

Automatically closed - issue fixed for 2 weeks with no activity.