Fix the issues reported by phpcs

Verified the patch is not applied to the latest version of the module. Tested on the latest 8.x-2.x version.

Still below PHPCS issues need to fix,

FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/Form/ConfigForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
 10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/web/modules/custom/menu_item_role_access/src/MenuItemRoleAccessLinkTreeManipulator.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
 79 | WARNING | MenuLinkContent::load calls should be avoided in classes, use dependency injection instead
 91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.

Needs work is for the issue summary that has not been updated.

Referring to the MR, there are still issues pending.

FILE: tests/src/Functional/PermissionsTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
 68 | ERROR | The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------


FILE: menu_item_role_access.module
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 24 | WARNING | Unused variable $config.
--------------------------------------------------------------------------------------


FILE: src/MenuItemRoleAccessLinkTreeManipulator.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
 79 | WARNING | MenuLinkContent::load calls should be avoided in classes, use dependency injection instead
 91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------

Time: 406ms; Memory: 10MB

Rebased and fixed all phpcs issues. Please consider MR-4 for review.

LiamPower → closed merge request !3

Hi,

I applied patch #20

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/menu_item_role_access (8.x-2.x)
$ curl https://git.drupalcode.org/project/menu_item_role_access/-/merge_requests/4.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2612    0  2612    0     0   7013      0 --:--:-- --:--:-- --:--:--  7040
patching file menu_item_role_access.module
patching file src/Form/ConfigForm.php
patching file src/MenuItemRoleAccessLinkTreeManipulator.php

Still showing error

Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib
$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml menu_item_role_access/

FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\menu_item_role_access\src\MenuItemRoleAccessLinkTreeManipulator.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 37 | ERROR | Parameter $module_handler is not described in comment
------------------------------------------------------------------------------------------------------------------------------------

Time: 332ms; Memory: 10MB

No phpcs issues report on running the command. Please review the MR.

Hi @nitin_lama,

I applied MR!4 and has not found any issues after running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  menu_item_role_access git:(c0999d0) ✗ curl https://git.drupalcode.org/project/menu_item_role_access/-/merge_requests/4.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7025    0  7025    0     0  19031      0 --:--:-- --:--:-- --:--:-- 19037
Checking patch menu_item_role_access.module...
Checking patch src/Form/ConfigForm.php...
Checking patch src/MenuItemRoleAccessLinkTreeManipulator.php...
Checking patch tests/src/Functional/MenuItemDisplayBrowserTestBase.php...
Hunk #2 succeeded at 70 (offset 5 lines).
Checking patch tests/src/Functional/PermissionsUpdateMenuLinkContentTest.php...
Checking patch tests/src/Functional/SpecialRoutesTest.php...
Applied patch menu_item_role_access.module cleanly.
Applied patch src/Form/ConfigForm.php cleanly.
Applied patch src/MenuItemRoleAccessLinkTreeManipulator.php cleanly.
Applied patch tests/src/Functional/MenuItemDisplayBrowserTestBase.php cleanly.
Applied patch tests/src/Functional/PermissionsUpdateMenuLinkContentTest.php cleanly.
Applied patch tests/src/Functional/SpecialRoutesTest.php cleanly.
➜  menu_item_role_access git:(c0999d0) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_item_role_access
➜  contrib git:(main) ✗

Thank you.

silvi.addweb → made their first commit to this issue’s fork.

I have applied the latest patch with MR !6 and it works proper.
All the Errors and warnings are solved.
Please check the Screenshot for the same.

LiamPower → closed merge request !6

LiamPower → closed merge request !4

Automatically closed - issue fixed for 2 weeks with no activity.