- Issue created by @sunil jolapara
- First commit to issue fork.
- 🇮🇳India kalash-j jaipur
kalash-j → changed the visibility of the branch 3452227- to hidden.
- Status changed to Needs review
7 months ago 11:03am 13 June 2024 - 🇵🇭Philippines clarkssquared
Hi
I applied the MR !1 but there are files being rejected as I apply it
➜ freshchat git:(master) ✗ curl https://git.drupalcode.org/project/freshchat/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2168 0 2168 0 0 2958 0 --:--:-- --:--:-- --:--:-- 2982 patching file README.md patching file README.txt patching file freshchat.info.yml 1 out of 1 hunks failed--saving rejects to freshchat.info.yml.rej
- Status changed to RTBC
7 months ago 5:11am 17 June 2024 Hi, MR!1 applied cleanly with any error or file rejection, Shared code snippet for reference.
RTBC ++
Thankyou.Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x) $ curl -o freshchat.patch https://git.drupalcode.org/project/freshchat/-/merge_requests/1.diff % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2168 0 2168 0 0 2714 0 --:--:-- --:--:-- --:--:-- 2716 Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x) $ git apply -v freshchat.patch Checking patch README.md... Checking patch README.txt... Checking patch freshchat.info.yml... Applied patch README.md cleanly. Applied patch README.txt cleanly. Applied patch freshchat.info.yml cleanly. Test@LAPTOP-6VFKUABC MINGW64 ~/freshchat (8.x-2.x)
- Status changed to Needs work
6 months ago 1:31pm 7 August 2024 Hello,
I have reviewed the MR!1 and found the MR is raised for branch 8.x-2.x whereas the version 3.0.0 is created from the branch 10.x. The changes made in the info.yml file is already present in the branch 10.x and due to this reason the MR!1 is failing in the current version. Changing the target branch might fix the patch fail issue.
Firstly I have cloned the repo, followed by applying the MR!1. Encountered the below errorerror: patch failed: freshchat.info.yml:1 error: freshchat.info.yml: patch does not apply
The readme file should use
Two lines prior to ##/### headings
as mentioned in https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or-distribution-project/documenting-your-project/readmemd-template → .