- 🇮🇳India dev16.addweb
Hi, While applying patch #2, It give me error. It might be version issue, And also found phpcs issue in latest version 4.0.0-alpha2. So change version and let's work on latest version
modules/custom/simplenews_scheduler# git apply -v 3127030-2.patch Checking patch simplenews_scheduler_views.inc... Checking patch src/Controller/EditionsController.php... Checking patch src/Tests/SimplenewsSchedulerDaylightSavingSwitchTest.php... Checking patch src/Tests/SimplenewsSchedulerEditionDueTest.php... Checking patch src/Tests/SimplenewsSchedulerEditionTimeTest.php... Checking patch src/Tests/SimplenewsSchedulerNextRunTimeTest.php... Checking patch src/Tests/SimplenewsSchedulerNodeCreationTest.php... error: while searching for: public static $modules = ['block']; function setUp() { parent::setUp(); $this->drupalPlaceBlock('local_tasks_block'); $admin_user = $this->drupalCreateUser(array( 'access content', 'administer nodes', 'create simplenews_issue content', error: patch failed: src/Tests/SimplenewsSchedulerNodeCreationTest.php:19 error: src/Tests/SimplenewsSchedulerNodeCreationTest.php: patch does not apply
- Issue was unassigned.
- Status changed to Needs review
12 months ago 5:57am 25 June 2024 - Status changed to Needs work
11 months ago 10:39am 12 July 2024 - 🇮🇳India sanket.addweb
Hi,
I have tested phpcs issue, some error is still remaining.web/modules/custom/simplenews_scheduler-3127030/simplenews_scheduler_views.inc ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------- 53 | ERROR | Missing parameter type 57 | ERROR | Missing parameter type ------------------------------------------------------------------------------------------------------------------------------------------------- Time: 387ms; Memory: 14MB
- Status changed to Needs review
11 months ago 10:43am 12 July 2024 - 🇮🇳India dev16.addweb
Hi,
I have fixed error mention on #6, Please review it. - Status changed to RTBC
11 months ago 11:05am 12 July 2024 - 🇮🇳India riddhi.addweb
The mentioned issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.
-
jocowood →
committed 80909f93 on 4.x authored by
silvi.addweb →
#3127030 Fix phpcs issues.
-
jocowood →
committed 80909f93 on 4.x authored by
silvi.addweb →
- 🇩🇪Germany jocowood Kamp-Lintfort
Looks good, everything runs as before, phpcs warnings are fixed. Merging and closing. Thank you all!
Automatically closed - issue fixed for 2 weeks with no activity.