- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:09am 19 May 2023 - Assigned to dineshkumarbollu
- Status changed to Needs work
over 1 year ago 9:35am 19 May 2023 - ๐ฎ๐ณIndia dineshkumarbollu
Hi
After appliny the patch it still found errors
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/quick_search_index_clone-3361429/
FILE: /var/www/html/vbd9/web/modules/contrib/quick_search_index_clone-3361429/quick_search_index_clone.routing.yml
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------FILE: /var/www/html/vbd9/web/modules/contrib/quick_search_index_clone-3361429/README.md
---------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------
14 | WARNING | [ ] Line exceeds 80 characters; contains 129 characters
15 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
30 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
47 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------Time: 231ms; Memory: 12MB
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:37am 19 May 2023 - ๐ต๐ญPhilippines clarkssquared
Hi dineshkumarbollu,
I applied your patch #4 and confirmed that all phpcs errors mentioned were fixed, but I retain this ticket to be in needs review because I want to hear from you or from the maintainer if the remaining phpcs warnings should be fixed or not.
Please look at the attached screenshot for your reference.
Thank you
- Status changed to Needs work
over 1 year ago 8:01am 20 May 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
-The Quick Search API Clone is a Drupal module that allows you to quickly clone an existing search API index and its dependencies, -like fields, facets, and processors. It also lets you customize the settings of the newly created index, +The Quick Search API Clone is a Drupal module that allows you to quickly clone +an existing search API index and its dependencies, +like fields, facets, and processors. It also lets you customize the settings of +the newly created index, such as the index name, server, and filters.
Avoiding that lines exceed 80 characters does not mean making them 23-character long.
/** - * Class IndexDuplicateForm. + * Class of IndexDuplicateForm.
That is still repeating the class name without describing what the class purpose is.
- Assigned to imustakim
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 9:40am 20 May 2023 - ๐ฎ๐ณIndia imustakim Ahmedabad
Patch updated and interdiff attached.
Please review. - ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- Status changed to RTBC
5 months ago 12:50pm 28 June 2024 - ๐ฎ๐ณIndia dev16.addweb
Hello,
I reviewed #10 and confirmed it fixes all the errors and warnings reported by phpcs and also raised MR for the same. Please review.
Thank You.