- Issue created by @sunil_lnwebworks
- 🇮🇳India Mohd Sahzad
Mohd Sahzad → made their first commit to this issue’s fork.
- Status changed to Needs review
3 months ago 11:57am 18 March 2024 - 🇮🇳India Preethy_ray
Hi,
I applied the patch, but it is throwing the following errors.git apply -v 3431293-phpcs-issue-fixed.patch 3431293-phpcs-issue-fixed.patch:9: trailing whitespace. This module uses sapientpro/image-comparator library Checking patch README.md... error: README.md: No such file or directory Checking patch src/Services/ImageComparatorService.php... error: src/Services/ImageComparatorService.php: No such file or directory Checking patch src/Services/ImageComparatorServiceInterface.php... error: src/Services/ImageComparatorServiceInterface.php: No such file or directoryThank You!!
- 🇵🇭Philippines clarkssquared
Hi
I applied MR !2 and I confirmed it fixes most of the PHPCS but there is line exceeding character warning.
➜ image_comparator git:(1.0.x) curl https://git.drupalcode.org/project/image_comparator/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 9185 0 9185 0 0 13861 0 --:--:-- --:--:-- --:--:-- 13980 patching file .gitlab-ci.yml patching file image_comparator.info.yml patching file 'src/Services/ImageComparatorService.php' patching file 'src/Services/ImageComparatorServiceInterface.php' ➜ image_comparator git:(1.0.x) ✗ .. ➜ contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml image_comparator FILE: ...subing/Projects/d9/d9-local/web/modules/contrib/image_comparator/README.md -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 3 | WARNING | Line exceeds 80 characters; contains 111 characters -------------------------------------------------------------------------------- Time: 201ms; Memory: 10MB ➜ contrib git:(master) ✗I will retain the status to needs review so that others can test it, and also to hear from the maintainer if this warning is intentional or intended for some purposes.