@sunil_lnwebworks

Already Fixed in the following commit will deploy in the new Release.
https://git.drupalcode.org/project/error_reporting/-/commit/b9fb381835b4...

Hi @all

I had the necessary code review fixes, as per your suggestion could you please review it.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

I had attached the patch file for the above Phpcs issues.

sunil_lnwebworks → created an issue.

Hi @clarkssquared

I had updated the patch could you please review it.

@Mohd Sahzad

There is issue in your changes, Please follow the drupal coding standard

Issue: TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"phpcs

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

Hi @kenyoOwen,

I've made updates to the Readme in accordance with the documentation. Please refer to the Patch File Updated-Readme-File.patch

Hi @cosmos

Thanks for considering my time and work! Looking forward to the next minor version with the patch applied

I got the following when I run the phpcs command

FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/lib/ProdNoRedirectDrupalKernel.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 10 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/prod_no_redirect.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------
➜  prod_no_redirect git:(master) ✗ /Users/mac/project/phpcs/vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml   /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect


FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/README.md
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
  7 | WARNING | Line exceeds 80 characters; contains 85 characters
 13 | WARNING | Line exceeds 80 characters; contains 120 characters
-----------------------------------------------------------------------------------------


FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/lib/ProdNoRedirectDrupalKernel.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
  8 | ERROR | [x] Missing class doc comment
 10 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/prod_no_redirect.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------


FILE: /Users/mac/contribution/my_site_name/web/modules/contrib/prod_no_redirect/src/EventSubscriber/ExceptionDetectNeedsInstallSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
 10 | ERROR | [ ] Namespaced classes/interfaces/traits should be referenced with use statements
 12 | ERROR | [x] Missing function doc comment
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------

Time: 63ms; Memory: 8MB

sunil_lnwebworks → created an issue.

I created a readme template where author can easily update the requirements as per need, Please refer to the attached Patch File

sunil_lnwebworks → created an issue.

I have updated the Info File as per module requirement, Please refer to the attached Patch File.

sunil_lnwebworks → created an issue.

I have updated the Info File as per module requirement, Please refer to the attached Patch File.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

I updated the README template in the following patch file, so that the maintainer can fill out the needed details for their module. Please refer to the attached patch file.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

Hi

I created a readme template where author can easily update the requirements as per need, Please refer to the attached Patch File

@ravi_kant

I updated the Readme template, In the following Patch File, so that maintainer can Filled out the needed details for his module, Please refer to the attached README-updated.patch

sunil_lnwebworks → created an issue.

Hi
I updated the Readme.txt to Readme.md , Please refer to the attached Patch File:

Hi
I updated the Readme.txt to Readme.md , Please refer to the attached Patch File:

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

I have updated the Info File as per module requirement, Please refer to the attached Patch File.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → changed the visibility of the branch 3427593-module-have-some to hidden.

Hi

Here is the Patch file for the above phpcs issues.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

sunil_lnwebworks → created an issue.

All the issues reported by PHPcs has been fixed in attached patch.
Please review
Thank you